http2: make compat writeHead not crash if the stream is destroyed

Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Feb 28, 2019 · d56a5e8 · d56a5e8
1 parent 850a1af
commit d56a5e8
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -568,6 +568,11 @@ class Http2ServerResponse extends Stream {
     if (this[kStream].headersSent)
       throw new ERR_HTTP2_HEADERS_SENT();
 
+    // If the stream is destroyed, we return false,
+    // like require('http').
+    if (this.stream.destroyed)
+      return false;
+
     if (typeof statusMessage === 'string')
       statusMessageWarn();
 

diff --git a/test/parallel/test-http2-compat-write-head-destroyed.js b/test/parallel/test-http2-compat-write-head-destroyed.js
@@ -0,0 +1,29 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+const http2 = require('http2');
+
+// Check that writeHead, write and end do not crash in compatibility mode
+
+const server = http2.createServer(common.mustCall((req, res) => {
+  // destroy the stream first
+  req.stream.destroy();
+
+  res.writeHead(200);
+  res.write('hello ');
+  res.end('world');
+}));
+
+server.listen(0, common.mustCall(() => {
+  const client = http2.connect(`http://localhost:${server.address().port}`);
+
+  const req = client.request();
+  req.on('response', common.mustNotCall());
+  req.on('close', common.mustCall((arg) => {
+    client.close();
+    server.close();
+  }));
+  req.resume();
+}));