src: elevate v8 namespaces of repeated artifacts #24427
Conversation
nodejs-github-bot
added
c++
gireeshpunathil
added
the
code-and-learn
|
👍 to fast-track |
|
The first line of the commit message should be shorter (<=50 characters if possible) |
Shubhamurkade
changed the title
Does it look good now? |
|
Hello @Shubhamurkade and welcome, and thank you for your contribution 🥇 P.S. If you have any questions you can also feel free to contact me directly. |
|
FYI: @Shubhamurkade if you'd like you can associate your email with your GitHub account. That way we and GitHub will credit the code contributions you make to you. See https://github.com/settings/emails and the guide at https://help.github.com/articles/setting-your-commit-email-address-on-github/ |
Hi @refack! I already have an email address associated with my github account. Please look at the attached image. |
|
@Shubhamurkade it seems like that's not the email you have setup in your local git. You can see the GitHub doesn't recognize it in this screen 787db0f I'll try to fix it for this PR while landing it. ✔️ |
refack
force-pushed
the
namespace_change
branch
from
787db0f
to
df8d89f
Compare
PR-URL: nodejs#24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
refack
force-pushed
the
namespace_change
branch
from
df8d89f
to
ea65519
Compare
|
@Shubhamurkade congratulations 🎉 on getting promoted by GitHub form: Hope to see you contributing again in the future! |
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Thank you! |
PR-URL: #24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: nodejs#24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
There are several places where v8 artifacts appear with scope resolution operator inline with the source. Elevated the places where the same artifacts were used repeatedly. The places where an artifact was used only once has been retained as it is.