Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky: parallel/test-https-agent-additional-options #24449

Closed
refack opened this issue Nov 17, 2018 · 13 comments
Closed

flaky: parallel/test-https-agent-additional-options #24449

refack opened this issue Nov 17, 2018 · 13 comments
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem.

Comments

@refack
Copy link
Contributor

refack commented Nov 17, 2018

  • Version: master
  • Platform: AIX
  • Subsystem: http
  • test file - parallel/test-https-agent-additional-options
  • ci job - aix/nodes=aix61-ppc64/18924/
  • ci worker - test-osuosl-aix61-ppc64_be-2
  • output:
     assert.js:86
       throw new AssertionError(obj);
       ^
     
     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
     
     6 !== 7
     
         at Agent.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-https-agent-additional-options.js:73:16)
         at Agent.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:346:15)
         at Object.onceWrapper (events.js:273:13)
         at Agent.emit (events.js:187:15)
         at TLSSocket.onFree (_http_agent.js:258:11)
         at TLSSocket.emit (events.js:182:13)
         at emitFreeNT (_http_client.js:628:10)
         at process.internalTickCallback (internal/process/next_tick.js:72:19)
@refack refack added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Nov 17, 2018
@richardlau
Copy link
Member

Copy/paste error? (platform and test do not match the CI links/output).

@refack
Copy link
Contributor Author

refack commented Nov 17, 2018

Yeah. I mangled #24397 instead 🤦‍♂️

@Trott
Copy link
Member

Trott commented Nov 24, 2018

Stress test: https://ci.nodejs.org/job/node-stress-single-test/2109/

RUN_TESTS: -J --repeat 10 parallel/test-https-agent-additional-options
RUN_TIMES: 100
RUN_LABEL: aix61-ppc64

@refack
Copy link
Contributor Author

refack commented Nov 24, 2018

1 out of 100 repeats failed
https://ci.nodejs.org/job/node-stress-single-test/2109/nodes=aix61-ppc64/testReport/junit/(root)/
With:

assert.js:86
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 7

    at Agent.<anonymous> (/home/iojs/build/workspace/node-stress-single-test/nodes/aix61-ppc64/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/home/iojs/build/workspace/node-stress-single-test/nodes/aix61-ppc64/test/common/index.js:346:15)
    at Object.onceWrapper (events.js:277:13)
    at Agent.emit (events.js:194:15)
    at TLSSocket.onFree (_http_agent.js:258:11)
    at TLSSocket.emit (events.js:189:13)
    at emitFreeNT (_http_client.js:628:10)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)

@gireeshpunathil
Copy link
Member

not recreate-able any more - ran enough time to arrive at that. And didn't see this as reported any time in the recent past. Probably we should close; and re-open if we see again?

@Trott
Copy link
Member

Trott commented Jan 29, 2019

Probably we should close; and re-open if we see again?

Did ncu-ci walk commit and there were no failures of this test. So that would be consistent with "This doesn't seem to be failing anymore."

@gireeshpunathil
Copy link
Member

closing as non-reproducible, re-open if found again.

@MylesBorins
Copy link
Contributor

MylesBorins commented May 16, 2019

Just showed up on 10.x arm

https://ci.nodejs.org/job/node-test-binary-arm/7686/RUN_SUBSET=3,label=pi1-docker/testReport/junit/(root)/test/parallel_test_https_agent_additional_options/

assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 6
+ 7
    at Agent.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-https-agent-additional-options.js:72:16)
    at Agent.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:379:15)
    at Object.onceWrapper (events.js:286:20)
    at Agent.emit (events.js:203:15)
    at TLSSocket.onFree (_http_agent.js:258:11)
    at TLSSocket.emit (events.js:198:13)
    at emitFreeNT (_http_client.js:622:10)
    at process._tickCallback (internal/process/next_tick.js:63:19)

@MylesBorins MylesBorins reopened this May 16, 2019
@Trott
Copy link
Member

Trott commented May 21, 2019

Just showed up on 10.x arm

On my way out the door to drop my kid at school and then get to work, but really fast: I suppose it's possible that it's only on 10.x and has been fixed on master. I might try to run a stress test later on master vs. v10.x-staging. If anyone does that before I get to it later, even better. :-D

@Trott
Copy link
Member

Trott commented May 21, 2019

Actually, no need for a stress test on CI as I can replicate this locally (on macOS Mojave):

$ tools/test.py -j96 --repeat 192 test/parallel/test-https-agent-additional-options.js 
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

5 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

5 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

5 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

5 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

5 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

5 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
=== release test-https-agent-additional-options ===                   
Path: parallel/test-https-agent-additional-options
assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

6 !== 7

    at Agent.<anonymous> (/Users/trott/io.js/test/parallel/test-https-agent-additional-options.js:73:16)
    at Agent.<anonymous> (/Users/trott/io.js/test/common/index.js:374:15)
    at Object.onceWrapper (events.js:288:20)
    at Agent.emit (events.js:205:15)
    at TLSSocket.onFree (_http_agent.js:265:11)
    at TLSSocket.emit (events.js:200:13)
    at emitFreeNT (_http_client.js:639:10)
    at processTicksAndRejections (internal/process/task_queues.js:84:9) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 6,
  expected: 7,
  operator: 'strictEqual'
}
Command: out/Release/node --tls-min-v1.1 /Users/trott/io.js/test/parallel/test-https-agent-additional-options.js
[00:16|% 100|+ 168|-  24]: Done                                       
$

@Trott
Copy link
Member

Trott commented May 22, 2019

@Trott
Copy link
Member

Trott commented May 22, 2019

Looks like the socket will sometimes close before the test completes, causing it to be removed from the pool Then it is missing from the pool when it is checked at the end of the test. Working up a fix (unless my conclusion here is wrong, in which case I'm working on a non-fix).

@Trott
Copy link
Member

Trott commented May 22, 2019

Looks like the socket will sometimes close before the test completes, causing it to be removed from the pool Then it is missing from the pool when it is checked at the end of the test. Working up a fix (unless my conclusion here is wrong, in which case I'm working on a non-fix).

#27830

Trott added a commit to Trott/io.js that referenced this issue May 23, 2019
test-https-agent-additional-options can occasionally fail if a socket
closes before the checks near the end of the test. Modify the test to
check the freeSockets pool after each request.

Fixes: nodejs#24449
@Trott Trott closed this as completed in 0d28300 May 25, 2019
targos pushed a commit that referenced this issue May 28, 2019
test-https-agent-additional-options can occasionally fail if a socket
closes before the checks near the end of the test. Modify the test to
check the freeSockets pool after each request.

PR-URL: #27830
Fixes: #24449
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem.
Projects
None yet
Development

No branches or pull requests

5 participants