Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: test: fixed the arguments order in #24227 #24413

Closed
wants to merge 3 commits into from
Closed

Fixes: test: fixed the arguments order in #24227 #24413

wants to merge 3 commits into from

Conversation

kanishk30
Copy link
Contributor

@kanishk30 kanishk30 commented Nov 17, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

The commit message should be changed to something like test: fix arguments order in napi test_exception

@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@gireeshpunathil
Copy link
Member

@kanishk30 - please state whether you can make the changes that @targos suggested or not. It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!

@Trott
Copy link
Member

Trott commented Nov 18, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/18728/

@Trott
Copy link
Member

Trott commented Nov 19, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18742/

@Trott
Copy link
Member

Trott commented Nov 19, 2018

Landed in c03c6e9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 19, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@kanishk30 @Trott
test: fix arguments order in napi test_exception
c03c6e9 
PR-URL: nodejs#24413
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 19, 2018
@kanishk30 @targos
test: fix arguments order in napi test_exception
6bedd17 
PR-URL: #24413
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@kanishk30 @rvagg
test: fix arguments order in napi test_exception
4348ffe 
PR-URL: #24413
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@kanishk30 @codebytere
test: fix arguments order in napi test_exception
d148bfc 
PR-URL: #24413
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@kanishk30 @refack
test: fix arguments order in napi test_exception
b6576a1 
PR-URL: nodejs#24413
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@kanishk30 @codebytere
test: fix arguments order in napi test_exception
644a9d6 
PR-URL: #24413
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@oyyd oyyd oyyd approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kanishk30 @targos @gireeshpunathil @Trott @jasnell @cjihrig @oyyd @trivikr @nodejs-github-bot