Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed the arguments order in assert.strictEqual #24227

Conversation

michael-zucker
Copy link
Contributor

This change was initiated from the NodeConfEU session.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This change was initiated from the NodeConfEU session.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 7, 2018
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2018
@gireeshpunathil
Copy link
Member

@gireeshpunathil
Copy link
Member

failures seem to be unrelated, re-run to be absolutely safe.
new CI: https://ci.nodejs.org/job/node-test-pull-request/18479/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 10, 2018
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24227
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 10, 2018

Landed in 6727f1c

@Trott Trott closed this Nov 10, 2018
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
This change was initiated from the NodeConfEU session.

PR-URL: #24227
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24227
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
kanishk30 added a commit to kanishk30/node that referenced this pull request Nov 17, 2018
codebytere pushed a commit that referenced this pull request Dec 13, 2018
This change was initiated from the NodeConfEU session.

PR-URL: #24227
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
This change was initiated from the NodeConfEU session.

PR-URL: #24227
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants