-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple project messaging. #24
Conversation
+1 for putting to bed "Evented I/O for V8 javascript", I've always hated that title |
your commit should be |
how do i alter commit messages after the fact? |
|
@TJkrusinski thanks! :) |
no problem! |
LGTM |
@mikeal Are you working on the governance section in https://github.com/mikeal/io.js/blob/readme-messaging/CONTRIBUTING.md#governance ? |
👍 |
releases, and contributorship are under an | ||
[open governance model](./CONTRIBUTING.md#governance). | ||
|
||
We intend to release, with increasing regularity, releases which are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is a bit awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think it's supposed to say io.js is under the "open governance model" but it reads like node.js is. Not trying to be nitpicky. This is a pretty important paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinohara80 +1, would you or @KyleAMathews mind putting in a PR to clarify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing that now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #36
Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #24
Landed in 51514c8! Thank you. |
rewords project messaging in README to make the overall project messaging a bit clearer. More discussion to be found in nodejs#24
Rewords project messaging in README to make the overall project messaging a bit clearer. More discussion to be found in #24. PR-URL: #36 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
This should put to bed some of the wilder speculation we've seen.