test: update certificates and private keys #22184
Conversation
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 9999 days for all of them to prevent this from happening again in near future. Fix: #22182
|
cc @MylesBorins @nodejs/crypto @bnoordhuis |
test/fixtures/keys/Makefile
Outdated
| @@ -27,6 +27,7 @@ ca3-key.pem: | |||
| ca3-csr.pem: ca3.cnf ca3-key.pem | |||
| openssl req -new \ | |||
| -extensions v3_ca \ | |||
| -days 9999 \ | |||
There was a problem hiding this comment.
Gosh, this slipped my quick review. It isn't really necessary, since the days are set in ca3.cnf.
There was a problem hiding this comment.
Should we remove it or just leave it?
|
@indutny no bueno test.parallel/test-crypto-sign-verify all failing https://ci.nodejs.org/job/node-test-commit-linux/20522/nodes=alpine-latest-x64/ |
|
Should be fixed now. |
|
I wonder if we shouldn't look at potentially dynamically generating these every so often |
|
one last ci with sn extra 9... giving us 273 years to figure this out instead of 27 |
|
Ah yes, good ole Node.js 557.0.0 |
|
@indutny still getting failures on arm https://ci.nodejs.org/job/node-test-binary-arm/2608/RUN_SUBSET=5,label=pi3-docker/console |
|
|
@mhdawson and I dug in a bunch and it seems like the failures on arm are infra related... potentially during setup @rvagg can you dig into this? One more ci: https://ci.nodejs.org/job/node-test-pull-request/16265/ landing if green |
|
parallel/test-tls-server-verify still failing on Raspberry Pi... |
MylesBorins
force-pushed
the
fix/ci-certs
branch
from
d82759a to
3e39945
Compare
|
oops... I did the status file wrong re-running arm https://ci.nodejs.org/job/node-test-commit-arm-fanned/2721/ |
|
Diagnosis & fix nodejs/build#1432 |
|
Manually kicked off a node-daily-master now that this has landed just to make sure I didn't get confused and we still have a problem or something: https://ci.nodejs.org/job/node-daily-master/1247/ |
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184 Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
Custom suites failed to |
|
Unrelated flaky on LinuxONE, re-running: https://ci.nodejs.org/job/node-test-commit-linuxone/3652/ |
|
Custom suites passed. |
|
LinuxONE passed. |
|
Argh, the |
|
|
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184 Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184 Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184 Fixes: #22182 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 9999 days for all of them to prevent this from
happening again in near future.
Fix: #22182
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes