Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] src: move Environment ctor/dtor into env.cc #21599

Closed
wants to merge 1 commit into from
Closed

[v8.x] src: move Environment ctor/dtor into env.cc #21599

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: #19202

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
src: move Environment ctor/dtor into env.cc
9977a76 
This makes it easier to use methods from other headers
in the constructor and destructor.

PR-URL: nodejs#19202
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/181/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8.x labels Jun 30, 2018
@addaleax
Copy link
Member Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15678/

MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
@addaleax @MylesBorins
src: move Environment ctor/dtor into env.cc
1aa1ff4 
This makes it easier to use methods from other headers
in the constructor and destructor.

Backport-PR-URL: #21599
PR-URL: #19202
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 1aa1ff4

rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
src: move Environment ctor/dtor into env.cc
2ee4bb7 
This makes it easier to use methods from other headers
in the constructor and destructor.

Backport-PR-URL: #21599
PR-URL: #19202
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @nodejs-github-bot @MylesBorins