Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: force through RST_STREAM in destroy #21016

Closed
wants to merge 1 commit into from
Closed

http2: force through RST_STREAM in destroy #21016

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented May 29, 2018 •
edited
Loading

If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream.

Fixes: #21008

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@apapirovski
http2: force through RST_STREAM in destroy
cbec767 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.
@apapirovski apapirovski added the http2 Issues or PRs related to the http2 subsystem. label May 29, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 29, 2018
@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15147/

@apapirovski apapirovski mentioned this pull request May 29, 2018
Closed
benjamingr
benjamingr approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work diagnosing this from that one assertion failure!

Code, test and changes LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018
@ronag
Copy link
Member

ronag commented May 30, 2018 •
edited
Loading

Is http2 still considered experimental? Otherwise, maybe this fix might be semi-urgent to get out?

@apapirovski
Copy link
Member Author

@ronag still experimental hence our ability to make breaking changes. That said, I would still consider this important to land soon. (So is #20997 which currently has 0 reviews though.)

@apapirovski apapirovski mentioned this pull request May 30, 2018
Closed
@Trott
Copy link
Member

Trott commented May 31, 2018

Re-running windows-fanned: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18404/

Re-running osx: https://ci.nodejs.org/job/node-test-commit-osx/18959/

Re-running smartos: https://ci.nodejs.org/job/node-test-commit-smartos/18018/

@apapirovski
Copy link
Member Author

Landed in 35858bb

@apapirovski apapirovski closed this Jun 1, 2018
@apapirovski apapirovski deleted the fix-http2-rst branch June 1, 2018 08:59
apapirovski added a commit that referenced this pull request Jun 1, 2018
@apapirovski
http2: force through RST_STREAM in destroy
35858bb 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

PR-URL: #21016
Fixes: #21008
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 1, 2018
@apapirovski @addaleax
http2: force through RST_STREAM in destroy
d4787cf 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

PR-URL: #21016
Fixes: #21008
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@apapirovski @kjin
http2: force through RST_STREAM in destroy
1322bea 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

PR-URL: nodejs#21016
Fixes: nodejs#21008
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@apapirovski @kjin
http2: force through RST_STREAM in destroy
f42f505 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

PR-URL: nodejs#21016
Fixes: nodejs#21008
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@apapirovski @kjin
http2: force through RST_STREAM in destroy
21f3e27 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

PR-URL: nodejs#21016
Fixes: nodejs#21008
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@apapirovski @BethGriggs
http2: force through RST_STREAM in destroy
b22266c 
If still needed, force through RST_STREAM in Http2Stream#destroy
calls, so that nghttp2 can wrap up properly and doesn't continue
trying to read & write data to the stream.

Backport-PR-URL: #22850
PR-URL: #21016
Fixes: #21008
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http2: assertion failed
8 participants
@apapirovski @ronag @Trott @jasnell @addaleax @benjamingr @BridgeAR @nodejs-github-bot