http2: delay closing stream #20997
Closed
http2: delay closing stream #20997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first.
nodejs-github-bot
added
dont-land-on-v4.x
http2
|
ping @nodejs/http2 would like to get this in the next release. |
mcollina
reviewed
May 29, 2018
| @@ -2178,7 +2181,7 @@ class ServerHttp2Stream extends Http2Stream { | |||
| let headRequest = false; | |||
| if (headers[HTTP2_HEADER_METHOD] === HTTP2_METHOD_HEAD) | |||
| headRequest = options.endStream = true; | |||
| options.readable = !options.endStream; | |||
| options.readable = false; | |||
There was a problem hiding this comment.
@jasnell I remember we discussed this, and you had a very good reason why this was there. Can you please weight in?
There was a problem hiding this comment.
I tested this extensively and I couldn't see a good reason. We (or nghttp2) don't let through any data from the other side as is anyway, so making the readable side open doesn't seem to make much sense... Would definitely love to know if there's something I missed though.
There was a problem hiding this comment.
If I am recalling correctly, this was there because of an earlier iteration. I don't think this is necessary now.
3 tasks
|
ping @jasnell — would appreciate your review, in particular whether we're safe to set |
jasnell
approved these changes
May 31, 2018
|
Landed in 87cd389 |
apapirovski
added a commit
that referenced
this pull request
Jun 1, 2018
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. PR-URL: #20997 Fixes: #20992 Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 1, 2018
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. PR-URL: #20997 Fixes: #20992 Reviewed-By: James M Snell <[email protected]>
Merged
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. PR-URL: nodejs#20997 Fixes: nodejs#20992 Reviewed-By: James M Snell <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. PR-URL: nodejs#20997 Fixes: nodejs#20992 Reviewed-By: James M Snell <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. PR-URL: nodejs#20997 Fixes: nodejs#20992 Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Backport-PR-URL: #22850 PR-URL: #20997 Fixes: #20992 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Also disable the
readableside of thepushStreamsince there should never be any data incoming.I'm not able to make a test since technically what we were doing was fine (and works with our own client) but the browsers seem a bit too strict.
Fixes: #20992
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes