stream: always defer readable in EOF when sync #18615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
mafintosh
reviewed
Feb 7, 2018
lib/_stream_readable.js
Outdated
| @@ -488,7 +488,7 @@ function onEofChunk(stream, state) { | |||
| } | |||
| state.ended = true; | |||
|
|
|||
| if (state.sync && state.length) { | |||
| if (state.sync) { | |||
| // if we are sync and have data in the buffer, wait until next tick | |||
There was a problem hiding this comment.
prob wanna remove the "and have data in the buffer" part of the comment now
|
👍 |
|
This can land, I propose to fast-track it to fix the CITGM failures. |
BridgeAR
approved these changes
Feb 7, 2018
cjihrig
approved these changes
Feb 7, 2018
benjamingr
approved these changes
Feb 7, 2018
|
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1264/ |
|
Landing now |
|
Landed as 87b9bce |
mcollina
added a commit
that referenced
this pull request
Feb 8, 2018
Fix a regression introduced by #18515 that broke the dicer module tests. See: #18515 PR-URL: #18615 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Should this be backported to |
|
This should not be backported. |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Fix a regression introduced by nodejs#18515 that broke the dicer module tests. See: nodejs#18515 PR-URL: nodejs#18615 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #18612
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream