stream: always defer readable in EOF when sync

Fix a regression introduced by #18515 that broke the dicer module tests. See: #18515 PR-URL: #18615 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Feb 8, 2018 · 87b9bce · 87b9bce
1 parent d8f7338
commit 87b9bce
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -488,9 +488,9 @@ function onEofChunk(stream, state) {
   }
   state.ended = true;
 
-  if (state.sync && state.length) {
-    // if we are sync and have data in the buffer, wait until next tick
-    // to emit the data. otherwise we risk emitting data in the flow()
+  if (state.sync) {
+    // if we are sync, wait until next tick to emit the data.
+    // Otherwise we risk emitting data in the flow()
     // the readable code triggers during a read() call
     emitReadable(stream);
   } else {

diff --git a/test/parallel/test-stream-readable-object-multi-push-async.js b/test/parallel/test-stream-readable-object-multi-push-async.js
@@ -160,7 +160,7 @@ const BATCH = 10;
   });
 
   readable.on('end', common.mustCall(() => {
-    assert.strictEqual(nextTickPassed, false);
+    assert.strictEqual(nextTickPassed, true);
   }));
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -160,7 +160,7 @@ const BATCH = 10; @@
       });
       readable.on('end', common.mustCall(() => {
-        assert.strictEqual(nextTickPassed, false);
+        assert.strictEqual(nextTickPassed, true);
       }));
     }
@@ Expand Down @@