Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: pass constant to logger instead of string #1842

Closed
wants to merge 1 commit into from
Closed

tools: pass constant to logger instead of string #1842

wants to merge 1 commit into from

Conversation

jbergstroem
Copy link
Member

On a few of our installations (namely CentOS), passing 'INFO' resulted in a silent loglevel. Use a logging constant instead.

/R=@Fishrock123, @rvagg

@jbergstroem
tools: pass constant to logger instead of string
2af605f 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.
@jbergstroem
Copy link
Member Author

Refs nodejs/build#104.

@mscdex mscdex added the test Issues and PRs related to the tests. label May 30, 2015
@rvagg
Copy link
Member

rvagg commented May 30, 2015

odd, lgtm if you're confirming this now works on those machines

@jbergstroem
Copy link
Member Author

This is from the 32-machine. Not sure why I don't see the same stuff in jenkins. Thoughts?

[root@iojs-build-centos5-32-1 io.js]# git checkout fix/centos_nologgingoutput
Branch fix/centos_nologgingoutput set up to track remote branch fix/centos_nologgingoutput from jbergstroem.
Switched to a new branch 'fix/centos_nologgingoutput'
[root@iojs-build-centos5-32-1 io.js]# /home/iojs/bin/python tools/test.py -p tap --logfile=/root/testtap.log
1..948
ok 1 - test-arm-math-exp-regress-1376.js
  ---
  duration_ms: 0.521
  ...
ok 2 - test-assert.js
  ---
<snip>
[root@iojs-build-centos5-32-1 io.js]# cat /root/testtap.log 
1..948
ok 1 - test-arm-math-exp-regress-1376.js
  ---
  duration_ms: 0.521
  ...
ok 2 - test-assert.js
  ---
<snip>

Edit: I was impatient; seems like its working as intended: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/735/nodes=centos6-64/console, https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/735/nodes=centos5-32/console

jbergstroem added a commit that referenced this pull request May 30, 2015
@jbergstroem
tools: pass constant to logger instead of string
8606793 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Fixes: nodejs/build#104
PR-URL: #1842
Reviewed-By: Rod Vagg <[email protected]>
@jbergstroem
Copy link
Member Author

Merged in 8606793. Thanks for the quick review, Rod.

@rvagg rvagg mentioned this pull request May 31, 2015
Merged
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
@jbergstroem @andrewdeandrade
tools: pass constant to logger instead of string
ac05d2b 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Fixes: nodejs/build#104
PR-URL: nodejs/node#1842
Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this pull request Jun 11, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
9a3d3ae 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this pull request Jul 7, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
6fcccfd 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this pull request Jul 8, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
c6d9963 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this pull request Jul 8, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
162fca4 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to nodejs/node-v0.x-archive that referenced this pull request Jul 10, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
d998a65 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #25653
orangemocha pushed a commit to orangemocha/node that referenced this pull request Jul 14, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
5c63645 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this pull request Jul 15, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
c309d9b 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to nodejs/node-v0.x-archive that referenced this pull request Jul 17, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
df59d43 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>

PR-URL: #25686
Reviewed-By: Julien Gilli <[email protected]>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
@jbergstroem @jBarz
tools: pass constant to logger instead of string
95567b2 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs#25653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbergstroem @rvagg @mscdex