Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centos 5 / 6 not running TAP tests #104

Closed
Fishrock123 opened this issue May 29, 2015 · 6 comments
Closed

Centos 5 / 6 not running TAP tests #104

Fishrock123 opened this issue May 29, 2015 · 6 comments

Comments

@Fishrock123
Copy link
Contributor

@evanlucas made a good find just now.

These build machines have not been running any tap tests under test-ci:

Centos5-32
Centos5-64
Centos6-64

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/nodes=centos5-32/731/
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/nodes=centos5-64/731/
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/nodes=centos6-64/731/

I looked back and this appears to be the case all the way back to late April when we started using test-ci + tap tests again.

Can we have Jenkins error if no tests were run? this just seems bad.

Centos7-64 however seems ok, it is showing tests run.

@rvagg / @jbergstroem / @nodejs/build
@jbergstroem
Copy link
Member

Investigating. Looks like the test runner bails:

/home/iojs/bin/python tools/test.py -p tap --logfile test.tap --mode=release message parallel sequential
make: *** [test-ci] Error 1
Build step 'Conditional steps (multiple)' marked build as failure

The annoying part is that the tap collector seems to pick up an empty tap file and seems happy to. It should not be run at all at that point.

@jbergstroem
Copy link
Member

-p tap just doesn't seem to produce output (but tests are being run successfully). I'll see what I can do.

@rvagg
Copy link
Member

rvagg commented May 30, 2015

eek, do we need to do something like test.py ... || echo "not ok >> test.tap to make sure the failure bubbles up?

@jbergstroem
Copy link
Member

@rvagg We can move the tap file creation further down or just remove the file if test.py exits abnormally . First I just want to figure out why logging behaves differently on the python versions we're running on centos. I'll have a look in an hour.

@jbergstroem
Copy link
Member

@rvagg actually - as long as we make sure output is written to the tap-file, it should stay regardless so we know what's going on.

@jbergstroem jbergstroem mentioned this issue May 30, 2015
Closed
jbergstroem added a commit to nodejs/node that referenced this issue May 30, 2015
@jbergstroem
tools: pass constant to logger instead of string
8606793 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Fixes: nodejs/build#104
PR-URL: #1842
Reviewed-By: Rod Vagg <[email protected]>
@jbergstroem
Copy link
Member

Fixed with nodejs/node@8606793.

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this issue Jun 3, 2015
@jbergstroem @andrewdeandrade
tools: pass constant to logger instead of string
ac05d2b 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Fixes: nodejs/build#104
PR-URL: nodejs/node#1842
Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this issue Jun 11, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
9a3d3ae 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this issue Jul 7, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
6fcccfd 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this issue Jul 8, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
c6d9963 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this issue Jul 8, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
162fca4 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to nodejs/node-v0.x-archive that referenced this issue Jul 10, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
d998a65 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: #25653
orangemocha pushed a commit to orangemocha/node that referenced this issue Jul 14, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
5c63645 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to orangemocha/node that referenced this issue Jul 15, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
c309d9b 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>
orangemocha pushed a commit to nodejs/node-v0.x-archive that referenced this issue Jul 17, 2015
@jbergstroem @orangemocha
tools: pass constant to logger instead of string
df59d43 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>

PR-URL: #25686
Reviewed-By: Julien Gilli <[email protected]>
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@jbergstroem @jBarz
tools: pass constant to logger instead of string
95567b2 
On a few of our installations (namely CentOS), passing 'INFO'
resulted in a silent loglevel. Use a logging constant instead.

Cherry-picked from nodejs/node@8606793
Original commit metadata follows:
  Fixes: nodejs/build#104
  PR-URL: nodejs/node#1842
  Reviewed-By: Rod Vagg <[email protected]>

Reviewed-By: Julien Gilli <[email protected]>
PR-URL: nodejs#25653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbergstroem @rvagg @Fishrock123