test: updated test-http-get-pipeline-problem.js to use fixtures module #16117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
code-and-learn
2 tasks
Instead of using common.fixturesDir, uses the fixtures module
|
LGTM. (I'm unable to approve in the GitHub interface because I opened this PR, but I didn't author the commit, so I think my LGTM still counts. :-D ) |
lpinca
approved these changes
Oct 10, 2017
watilde
approved these changes
Oct 10, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2017
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: nodejs#16117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 87ee0b6. @NigelKibodeaux Thanks for the contribution! 🎉 |
|
@Trott My pleasure! |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: nodejs/node#16117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: #16117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2017
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: #16117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: #16117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Instead of using common.fixturesDir, uses the fixtures module in test-http-get-pipeline-problem. PR-URL: #16117 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #15842. Ping @NigelKibodeaux
Instead of using common.fixturesDir, uses the fixtures module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http