updated test-http-get-pipeline-problem.js to use fixtures module #15842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelgolda
reviewed
Oct 6, 2017
| @@ -32,7 +33,7 @@ http.globalAgent.maxSockets = 1; | |||
|
|
|||
| common.refreshTmpDir(); | |||
|
|
|||
| const image = fs.readFileSync(`${common.fixturesDir}/person.jpg`); | |||
| const image = fs.readFileSync(fixtures.path('/person.jpg')); | |||
There was a problem hiding this comment.
This could be using method fixtures.readSync instead of fs.readFileSync and fixtures.path.
Trott
added
the
code-and-learn
|
Hmmm...I was trying to rebase out some extraneous commits and it closed the PR. I'll see if I can fix this... |
2 tasks
|
Continued at #16117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building a path to a fixture using the
fixturesDirproperty of the common module, this change will use thefixtures.path()function to build that path.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test