test: fix test-net-dns-custom-lookup test assertion #1531

evanlucas · 2015-04-26T13:53:38Z

The assertion made an assumption that the IPv6 address would always be
::1. Since the address can be different on different platforms, it
has been changed to allow multiple addresses.

Ref: #1527

jbergstroem · 2015-04-27T04:16:58Z

I'd rather put ::1 localhost in /etc/hosts.

rvagg · 2015-04-27T04:26:17Z

I'd rather put ::1 localhost in /etc/hosts.

I'd rather not because it seems to be the norm for it not to be there for Ubuntu and CentOS/RHEL 7 and we need these tests to run on machines other than the build machines without needing to know something like this.

jbergstroem · 2015-04-27T04:36:35Z

Seems like ip6-localhost needs to go in after all (based on this list).

jbergstroem · 2015-04-27T04:39:13Z

test/parallel/test-net-dns-custom-lookup.js

@@ -12,14 +18,16 @@ function check(addressType, cb) {
  });

  var address = addressType === 4 ? '127.0.0.1' : '::1';
+  var host = addressType === 4 ? 'localhost' : 'ip6-localhost';


This needs to support both localhost and ip6-localhost for 6-type families.

evanlucas · 2015-04-27T15:24:45Z

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/620/

Modifications were made to manually specify the IP in the custom lookup function. CI seems to like it now.

rvagg · 2015-04-28T04:15:50Z

so many failures .. what's going on with our tests!?

evanlucas · 2015-04-28T05:44:22Z

From just looking at the CI results, it looks like some tests are hanging up. Not really sure why yet.

jbergstroem · 2015-04-28T05:45:52Z

@evanlucas we're cancelling builds and restarting Jenkins.

rvagg · 2015-04-28T05:57:20Z

lgtm @evanlucas see https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/630/ && #1544, merge this baby and we'll get this sorted out

The assertion made an assumption that the IPv6 address would always be `::1`. Since the address can be different on different platforms, it has been changed to allow multiple addresses. Fixes: nodejs#1527 PR-URL: nodejs#1531 Reviewed-By: Rod Vagg <[email protected]>

Use fixtures.readKey() rather than common.fixturesDir in test-regress-nodejsGH-1531. PR-URL: nodejs#16811 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Use fixtures.readKey() rather than common.fixturesDir in test-regress-GH-1531. PR-URL: #16811 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

evanlucas added dns Issues and PRs related to the dns subsystem. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Apr 26, 2015

evanlucas force-pushed the fix-dns-custom-tests branch 2 times, most recently from b70703e to 99cb989 Compare April 27, 2015 02:14

jbergstroem reviewed Apr 27, 2015
View reviewed changes

evanlucas force-pushed the fix-dns-custom-tests branch 2 times, most recently from 466ba1e to ef6480d Compare April 27, 2015 15:01

rvagg mentioned this pull request Apr 28, 2015

remove -J from test-ci and fix test-net-dns-custom-lookup #1544

Merged

evanlucas force-pushed the fix-dns-custom-tests branch from ef6480d to bfae823 Compare April 28, 2015 06:03

evanlucas closed this Apr 28, 2015

evanlucas deleted the fix-dns-custom-tests branch April 28, 2015 06:03

evanlucas merged commit bfae823 into nodejs:master Apr 28, 2015

rvagg mentioned this pull request Apr 28, 2015

Release proposal: v2.0.0 #1532

Closed

ryzokuken mentioned this pull request Mar 6, 2018

test: rename regression tests with descriptive file names #19161

Closed

8 tasks

ryzokuken mentioned this pull request Mar 7, 2018

test: rename regression tests with descriptive file names #19212

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix test-net-dns-custom-lookup test assertion #1531

test: fix test-net-dns-custom-lookup test assertion #1531

evanlucas commented Apr 26, 2015

jbergstroem commented Apr 27, 2015

rvagg commented Apr 27, 2015

jbergstroem commented Apr 27, 2015

jbergstroem Apr 27, 2015

evanlucas commented Apr 27, 2015

rvagg commented Apr 28, 2015

evanlucas commented Apr 28, 2015

jbergstroem commented Apr 28, 2015

rvagg commented Apr 28, 2015

test: fix test-net-dns-custom-lookup test assertion #1531

test: fix test-net-dns-custom-lookup test assertion #1531

Conversation

evanlucas commented Apr 26, 2015

jbergstroem commented Apr 27, 2015

rvagg commented Apr 27, 2015

jbergstroem commented Apr 27, 2015

jbergstroem Apr 27, 2015

Choose a reason for hiding this comment

evanlucas commented Apr 27, 2015

rvagg commented Apr 28, 2015

evanlucas commented Apr 28, 2015

jbergstroem commented Apr 28, 2015

rvagg commented Apr 28, 2015