Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add known-issue test for issue 14441 #14488

Closed
wants to merge 1 commit into from
Closed

test: add known-issue test for issue 14441 #14488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions test/known_issues/test-assert-deepEqual-circular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';
require('../common');

// Refs: https://github.com/nodejs/node/issues/14441

const assert = require('assert');

{
const a = {};
const b = {};
a.a = a;
b.a = {};
b.a.a = a;
assert.deepEqual(b, a); // eslint-disable-line no-restricted-properties
assert.deepEqual(a, b); // eslint-disable-line no-restricted-properties
}

{
const a = new Set();
const b = new Set();
const c = new Set();
a.add(a);
b.add(b);
c.add(a);
assert.deepEqual(c, b); // eslint-disable-line no-restricted-properties
assert.deepEqual(b, c); // eslint-disable-line no-restricted-properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. It’s not totally obvious to me that the correct behaviour is to not throw in both cases, to me the issues seems to be more that deepEqual doesn’t behave symmetrically here…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a set that has a single entry: a set that has a set as only entry that is circular. And that should be the same as a set that has itself as single entry.

I already have the fix for the issue but I am still in the office and I will open a PR with the fix for these later on.

}