test: add known-issue test for issue 14441 #14488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
assert
addaleax
approved these changes
Jul 25, 2017
| b.add(b); | ||
| c.add(a); | ||
| assert.deepEqual(c, b); // eslint-disable-line no-restricted-properties | ||
| assert.deepEqual(b, c); // eslint-disable-line no-restricted-properties |
There was a problem hiding this comment.
Hm. It’s not totally obvious to me that the correct behaviour is to not throw in both cases, to me the issues seems to be more that deepEqual doesn’t behave symmetrically here…
There was a problem hiding this comment.
It is a set that has a single entry: a set that has a set as only entry that is circular. And that should be the same as a set that has itself as single entry.
I already have the fix for the issue but I am still in the office and I will open a PR with the fix for these later on.
|
I opened a fix (#14491), so I guess this is not needed as intermediate step anymore. |
|
Closing in favor of #14491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #14441
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test assert