Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: name some anonymous functions #14297

Closed
wants to merge 1 commit into from
Closed

readline: name some anonymous functions #14297

wants to merge 1 commit into from

Conversation

Amunu
Copy link
Contributor

@Amunu Amunu commented Jul 16, 2017 •
edited
Loading

Refs: #8913
Refs: #14297 (review)

Checklist
  • make -j4 test
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

readline

@nodejs-github-bot nodejs-github-bot added string_decoder Issues and PRs related to the string_decoder subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. tty Issues and PRs related to the tty subsystem. util Issues and PRs related to the built-in util module. labels Jul 16, 2017
Trott
Trott previously requested changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These function don't need to be named, but there are anonymous functions used as listeners in some files (such as lib/readline.js) that should probably be named. Do you want to try to name those?

@Amunu Amunu changed the title lib: name anonymous functions readline: name some anonymous functions Jul 20, 2017
@Amunu
Copy link
Contributor Author

Amunu commented Jul 20, 2017

@Trott I've updated the code and PR message.

@Trott Trott dismissed their stale review July 20, 2017 04:28

significant changes, dismissing review

@Trott
Copy link
Member

Trott commented Jul 20, 2017

Great! Thanks! Looks like there's conflicts. Can you rebase against master and resolve them?

@Amunu
Copy link
Contributor Author

Amunu commented Jul 20, 2017

@Trott I've rebased the code.

@XadillaX XadillaX added readline Issues and PRs related to the built-in readline module. and removed string_decoder Issues and PRs related to the string_decoder subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. tty Issues and PRs related to the tty subsystem. util Issues and PRs related to the built-in util module. labels Jul 20, 2017
XadillaX
XadillaX approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XadillaX
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9268/

@XadillaX XadillaX mentioned this pull request Jul 20, 2017
Closed
3 tasks
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 20, 2017
@XadillaX
Copy link
Contributor

@Trott, I'm not sure that whether CI is OK or not.

@Trott
Copy link
Member

Trott commented Jul 23, 2017

@XadillaX CI is fine. The one failure is test-crypto-dh-leak which is a known flaky test.

@XadillaX
Copy link
Contributor

Landed in f37e3b1. Thanks.

@XadillaX XadillaX closed this Jul 23, 2017
XadillaX pushed a commit that referenced this pull request Jul 23, 2017
@Amunu @XadillaX
readline: name some anonymous functions
f37e3b1 
PR-URL: #14297
Refs: #8913
Refs: #14297 (review)
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax
Copy link
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the dont-land-on label.

jasnell pushed a commit that referenced this pull request Sep 25, 2017
@Amunu @jasnell
readline: name some anonymous functions
8eeaba6 
PR-URL: #14297
Refs: #8913
Refs: #14297 (review)
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Amunu @Trott @XadillaX @addaleax @jasnell @cjihrig @MylesBorins @nodejs-github-bot