Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test-crypto-dh-leak flaky #14424

Closed
refack opened this issue Jul 22, 2017 · 3 comments
Closed

test: test-crypto-dh-leak flaky #14424

refack opened this issue Jul 22, 2017 · 3 comments
Labels
arm Issues and PRs related to the ARM platform. crypto Issues and PRs related to the crypto subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@refack
Copy link
Contributor

refack commented Jul 22, 2017

  • Version: master
  • Platform: ubuntu1604-arm64
  • Subsystem: test,crypto

A new test introduced in #14122. Flaky probably because the allowed wiggle room is too tight.
https://ci.nodejs.org/job/node-test-commit-arm/11062/nodes=ubuntu1604-arm64/

not ok 277 parallel/test-crypto-dh-leak
  ---
  duration_ms: 2.497
  severity: fail
  stack: |-
    assert.js:43
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: false == true
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/parallel/test-crypto-dh-leak.js:26:1)
        at Module._compile (module.js:569:30)
        at Object.Module._extensions..js (module.js:580:10)
        at Module.load (module.js:503:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)
        at Function.Module.runMain (module.js:605:10)
        at startup (bootstrap_node.js:158:16)
        at bootstrap_node.js:575:3
  ...

Code:

// RSS should stay the same, ceteris paribus, but allow for
// some slop because V8 mallocs memory during execution.
assert(after - before < 5 << 20);

/cc @bnoordhuis

@refack refack added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels Jul 22, 2017
@Trott
Copy link
Member

Trott commented Jul 23, 2017

Saw it somewhere else. Hope this one isn't going to pop up too frequently....

https://ci.nodejs.org/job/node-test-commit-arm/11038/nodes=ubuntu1604-arm64/console

not ok 264 parallel/test-crypto-dh-leak
  ---
  duration_ms: 1.962
  severity: fail
  stack: |-
    assert.js:43
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: false == true
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/parallel/test-crypto-dh-leak.js:26:1)
        at Module._compile (module.js:569:30)
        at Object.Module._extensions..js (module.js:580:10)
        at Module.load (module.js:503:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)
        at Function.Module.runMain (module.js:605:10)
        at startup (bootstrap_node.js:158:16)
        at bootstrap_node.js:575:3
  ...

@bnoordhuis
Copy link
Member

#14451

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jul 27, 2017
Fixes: nodejs#14424
PR-URL: nodejs#14451
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@bnoordhuis
Copy link
Member

Fixed by 1fa67c7.

addaleax pushed a commit that referenced this issue Jul 27, 2017
Fixes: #14424
PR-URL: #14451
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. crypto Issues and PRs related to the crypto subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants