Skip to content

deps,win: set MSVS .obj folders in gyp for V8 #13959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

deps,win: set MSVS .obj folders in gyp for V8 #13959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a4ff7
deps,win: set MSVS .obj folders in gyp for V8
jaimecbernardo Jun 21, 2017
4ccd87b
fixup: replace forward slashes
jaimecbernardo Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions deps/v8/src/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1793,6 +1793,13 @@
# limit. This breaks it into multiple pieces to avoid the limit.
# See http://crbug.com/485155.
'msvs_shard': 4,
# This will prevent V8's .cc files conflicting with the inspector's
# .cpp files in the same shard.
'msvs_settings': {
'VCCLCompilerTool': {
'ObjectFile':'$(IntDir)/%(Extension)/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request: replace last / with \\ (GYP shenanigans 🤷‍♂️ )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, even worse $(IntDir)%(Extension)\\

Copy link
Contributor Author

@jaimecbernardo jaimecbernardo Jun 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you mean you want the line changed like this: 'ObjectFile':'$(IntDir)%(Extension)\\',?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing it locally and then I'll submit a commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Changes committed: 4ccd87b

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

},
},
}],
['component=="shared_library"', {
'defines': [
Expand Down