Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps,win: set MSVS .obj folders in gyp for V8 #13959

Closed

Commits on Jun 27, 2017

  1. deps,win: set MSVS .obj folders in gyp for V8

    Building on Windows fails depending on the result from sharding the
    deps/v8/src/v8.gyp:v8_base target. If two source files with the same
    name are in the same shard, their output object file path would
    conflict with one another. One example of this conflict is v8_base's
    runtime/runtime.cc and the V8 inspector's protocol/Runtime.cpp that
    is generated at build time, for which the files runtime.obj and
    Runtime.obj would be created, but msvs overwrites one of them with
    the other.
    
    Dividing the .obj output path by the original source's extension
    prevents this overwrite.
    
    Fixes: nodejs/v8#4
    jaimecbernardo committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    08a4ff7 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2017

  1. Configuration menu
    Copy the full SHA
    4ccd87b View commit details
    Browse the repository at this point in the history