[v6.x] addons: remove semicolons from after module definition

[gabrielschulhof]

Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[gabrielschulhof]

Re #12919
@MylesBorins there's no NODE_MODULE_CONTEXT_AWARE_BUILTIN in src/node.cc in v6.x.

[gabrielschulhof]

bump

[addaleax]

@gabrielschulhof Usually, these PRs are handled by the person managing the next release – maybe @gibfahn wants to merge this right now, but most of the time there’s no need to bump, it will get sorted out in time. :)

Also, just so you know, backports should target the staging branches if possible (that doesn’t seem to be a problem here), and it’s nice if you edit the PR description in some way so people don’t think it’s a new PR when glancing over it. :)

[gabrielschulhof]

@addaleax thanks for the pointers! I'll keep these in mind for next time :)

[MylesBorins]

@gabrielschulhof which PR is this a backport of? We should have the original commit meta data including all sign offs in the commit message

[gabrielschulhof]

@MylesBorins sorry I didn't follow SOP on this.

2767209 and #12919

[gabrielschulhof]

@MylesBorins should I update the commit message?

[MylesBorins]

@gabrielschulhof indeed

the message should be

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: #12919
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>

We usually then add a Backport-PR-URL: https://github.com/nodejs/node/pull/13879 when landing

[gabrielschulhof]

@MylesBorins done. Thanks @MylesBorins and @addaleax for the guidance!

[MylesBorins]

landed in 8850007