Skip to content

Commit

Permalink
addons: remove semicolons from after module definition
Browse files Browse the repository at this point in the history
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: #12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Gabriel Schulhof authored and addaleax committed May 15, 2017

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
1 parent b23d414 commit 2767209
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion benchmark/misc/function_call/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ extern "C" void init (Local<Object> target) {
NODE_SET_METHOD(target, "hello", Hello);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion doc/api/addons.md
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,7 @@ void init(Local<Object> exports) {
AtExit(at_exit_cb1, exports->GetIsolate());
}

NODE_MODULE(addon, init);
NODE_MODULE(addon, init)

} // namespace demo
```
Expand Down
2 changes: 1 addition & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4618,5 +4618,5 @@ int Start(int argc, char** argv) {
#if !HAVE_INSPECTOR
static void InitEmptyBindings() {}

NODE_MODULE_CONTEXT_AWARE_BUILTIN(inspector, InitEmptyBindings);
NODE_MODULE_CONTEXT_AWARE_BUILTIN(inspector, InitEmptyBindings)
#endif // !HAVE_INSPECTOR
2 changes: 1 addition & 1 deletion src/node_contextify.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1033,4 +1033,4 @@ void InitContextify(Local<Object> target,
} // anonymous namespace
} // namespace node

NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify);
NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify)
2 changes: 1 addition & 1 deletion test/addons/async-hello-world/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/at-exit/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ void init(Local<Object> exports) {
atexit(sanity_check);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/buffer-free-callback/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "check", Check);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/hello-world-function-export/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
NODE_SET_METHOD(module, "exports", Method);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/hello-world/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/load-long-path/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/null-buffer-neuter/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "run", Run);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/parse-encoding/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ void Initialize(v8::Local<v8::Object> exports) {

} // anonymous namespace

NODE_MODULE(binding, Initialize);
NODE_MODULE(binding, Initialize)
2 changes: 1 addition & 1 deletion test/addons/repl-domain-abort/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ void init(Local<Object> exports) {
NODE_SET_METHOD(exports, "method", Method);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/stringbytes-external-exceed-max/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "ensureAllocation", EnsureAllocation);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)
2 changes: 1 addition & 1 deletion test/addons/symlinked-module/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(binding, init);
NODE_MODULE(binding, init)

0 comments on commit 2767209

Please sign in to comment.