Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove Gitter badge from README #13231

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 26, 2017

Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter.

Checklist
Affected core subsystem(s)

doc

@Trott Trott added the doc Issues and PRs related to the documentations. label May 26, 2017
@Trott Trott changed the title doc: remove low-value badges from README doc: remove badges from README May 26, 2017
@Trott Trott force-pushed the we-dont-need-no-stinking-badges branch from 3f48bf6 to 8729811 Compare May 26, 2017 05:46
@evanlucas
Copy link
Contributor

/cc @rvagg since you helped get the CII badge added in #6819

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and 👍 to the branch name

Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, they are pretty much noise.

@jasnell
Copy link
Member

jasnell commented May 28, 2017

I'm +1 on removing the gitter badge. My preference on the CII badge would be to simply move it further down the page... perhaps at the bottom just as additional information.

@Trott Trott force-pushed the we-dont-need-no-stinking-badges branch 4 times, most recently from 490e507 to c771b9a Compare May 29, 2017 15:29
@Trott
Copy link
Member Author

Trott commented May 29, 2017

Since there is some hesitation at removing the Core Infrastructure Initiative badge, I've dialed this back to just removing the Gitter badge, for which there is consensus. (If anyone wants to either relocate or remove the CII badge too, please open another PR!)

@Trott Trott changed the title doc: remove badges from README doc: remove gitter badge from README May 29, 2017
@Trott Trott force-pushed the we-dont-need-no-stinking-badges branch from c771b9a to dad32c1 Compare May 29, 2017 15:35
@Trott Trott changed the title doc: remove gitter badge from README doc: remove Gitter badge from README May 29, 2017
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.
@Trott Trott force-pushed the we-dont-need-no-stinking-badges branch from dad32c1 to cb11574 Compare May 29, 2017 15:36
Trott added a commit to Trott/io.js that referenced this pull request May 29, 2017
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

PR-URL: nodejs#13231
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 29, 2017

Landed in 19fdb54

@Trott Trott closed this May 29, 2017
@refack refack mentioned this pull request May 29, 2017
3 tasks
@refack
Copy link
Contributor

refack commented May 29, 2017

(If anyone wants to either relocate or remove the CII badge too, please open another PR!)

#13283

jasnell pushed a commit that referenced this pull request May 29, 2017
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

PR-URL: #13231
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@cjihrig cjihrig mentioned this pull request Jun 6, 2017
4 tasks
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
Remove the Gitter badge.

Gitter is not supported by us. We use IRC channels on Freenode. Having
the Gitter badge is confusing because we list different resources
later in the doc and never mention Gitter.

PR-URL: #13231
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
@gibfahn gibfahn mentioned this pull request Feb 21, 2018
3 tasks
@Trott Trott deleted the we-dont-need-no-stinking-badges branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.