-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove Gitter badge from README #13231
Conversation
3f48bf6
to
8729811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and 👍 to the branch name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, they are pretty much noise.
I'm +1 on removing the gitter badge. My preference on the CII badge would be to simply move it further down the page... perhaps at the bottom just as additional information. |
490e507
to
c771b9a
Compare
Since there is some hesitation at removing the Core Infrastructure Initiative badge, I've dialed this back to just removing the Gitter badge, for which there is consensus. (If anyone wants to either relocate or remove the CII badge too, please open another PR!) |
c771b9a
to
dad32c1
Compare
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter.
dad32c1
to
cb11574
Compare
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: nodejs#13231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Landed in 19fdb54 |
|
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: #13231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter. PR-URL: #13231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Remove the Gitter badge. Gitter is not supported by us. We use IRC channels on Freenode. Having the Gitter badge is confusing because we list different resources later in the doc and never mention Gitter.
Checklist
Affected core subsystem(s)
doc