Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack Node.js Community #1777

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Add Slack Node.js Community #1777

merged 3 commits into from
Mar 25, 2019

Conversation

aymen94
Copy link
Member

@aymen94 aymen94 commented Feb 16, 2019

Added Slack Node.js Community

@ljharb
Copy link
Member

ljharb commented Mar 23, 2019

cc @Trott

@Trott
Copy link
Member

Trott commented Mar 24, 2019

So, the reason Slack is not on there is because it's not an official affiliated-with-the-Foundation chat like the other two were. Gitter, though, was shut down and should be removed.

I think the Node.js Slack adopted our Code of Conduct and there may be an argument to include it, although I don't know if it should be listed separately as unofficial like it is in the core repo. Let's /ping @nodejs/community-committee for that.

Anyway, this change is fine by me.

@ljharb
Copy link
Member

ljharb commented Mar 24, 2019

@Trott it did adopt it; myself and other members of the moderation team are some of the admins of it.

@ljharb
Copy link
Member

ljharb commented Mar 24, 2019

As for the gitter, it's just as much as in use as it's been for years - i think you mean it's discord that was shut down.

@Trott
Copy link
Member

Trott commented Mar 24, 2019

As for the gitter, it's just as much as in use as it's been for years - i think you mean it's discord that was shut down.

No, I'm thinking of this: nodejs/node#13231 It wasn't the lack of use that got it removed as much as the lack of moderation, I think... See also nodejs/node#13502 (comment). Anyway, all that was from 2017 and the Community Committee was just getting started. I'm happy to defer to them on guidelines for this stuff now. I do think we would be wise to choose only a very small number of durable high-quality resources and resist adding lots and lots of things. It's better for the user if there are only two things that are great and not two things that are great but they get lost in a list of 90 things that are hit-and-miss.

@Trott
Copy link
Member

Trott commented Mar 24, 2019

(You're right, though, that the gitter was not shut down, obviously. I got that wrong for sure!)

@Bamieh
Copy link

Bamieh commented Mar 25, 2019

We use it as our main communication channel for mentorship. we also have a community committee channel there. I'd encourage having it on the list even if we label it * unofficial *

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on CommComm member feedback, this LGTM. Would be great if we removed Gitter at the same time.

README.md Outdated
@@ -41,6 +41,8 @@ this repository, you can try:

* [Freenode #node.js channel](https://webchat.freenode.net/?channels=node.js&uio=d4)
* [Gitter Node.js room](https://gitter.im/nodejs/node)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the Gitter line while we're in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 😄

@Trott Trott merged commit 780d3ee into nodejs:master Mar 25, 2019
@nodejs nodejs deleted a comment Dec 12, 2019
@anhthiet92buh

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants