Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: harmonize progress bar and stderr output #11925

Closed
wants to merge 1 commit into from
Closed

benchmark: harmonize progress bar and stderr output #11925

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 19, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

_benchmark_progress.js does not work well with stderr output:

  1. It sticks together with error messages which throw and abort runs. See this comment for an example.

  2. It still sticks together with error messages which do not throw and do not abort runs. At that, it starts to duplicate with each such message. For example, there is misc/function_call which calls console.error() most of the time the misc suite is launched. So the output is something like this:

compare.js --old ... --new ... --filter function_call misc > bm.csv

misc/function_call.js Binding failed to load
[00:00:02|%   1| 0/1 files |  1/60 runs | 0/0 configs]: misc\function_callmisc/function_call.js Binding failed to load
[00:00:02|%   3| 0/1 files |  2/60 runs | 0/0 configs]: misc\function_callmisc/function_call.js Binding failed to load
[00:00:03|%   5| 0/1 files |  3/60 runs | 0/0 configs]: misc\function_callmisc/function_call.js Binding failed to load
[00:00:04|%   6| 0/1 files |  4/60 runs | 0/0 configs]: misc\function_callmisc/function_call.js Binding failed to load
[00:00:04|%   8| 0/1 files |  5/60 runs | 0/0 configs]: misc\function_callmisc/function_call.js Binding failed to load
...
[00:00:37|%  98| 0/1 files | 59/60 runs | 0/0 configs]: misc\function_callmisc/function_call.js Binding failed to load
[00:00:37|% 100| 1/1 files | 60/60 runs | 0/0 configs]: Done

Till some drastic solution is applied, this commit just adds a space in the end of the bar for minimal readability. So the abovementioned output could be at least something like this:

compare.js --old ... --new ... --filter function_call misc > bm.csv

misc/function_call.js Binding failed to load
[00:00:02|%   1| 0/1 files |  1/60 runs | 0/0 configs]: misc\function_call misc/function_call.js Binding failed to load
[00:00:02|%   3| 0/1 files |  2/60 runs | 0/0 configs]: misc\function_call misc/function_call.js Binding failed to load
[00:00:03|%   5| 0/1 files |  3/60 runs | 0/0 configs]: misc\function_call misc/function_call.js Binding failed to load
[00:00:03|%   6| 0/1 files |  4/60 runs | 0/0 configs]: misc\function_call misc/function_call.js Binding failed to load
[00:00:04|%   8| 0/1 files |  5/60 runs | 0/0 configs]: misc\function_call misc/function_call.js Binding failed to load
...
[00:00:36|%  98| 0/1 files | 59/60 runs | 0/0 configs]: misc\function_call misc/function_call.js Binding failed to load
[00:00:37|% 100| 1/1 files | 60/60 runs | 0/0 configs]: Done

Add a space for minimal readability.
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Mar 19, 2017
@vsemozhetbyt
Copy link
Contributor Author

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I think the fix is probably going to be in _common.js and compare.js, the progress bar doesn't know much about the processes.

jasnell pushed a commit that referenced this pull request Mar 22, 2017
Add a space for minimal readability.

PR-URL: #11925
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

Landed in 4b841cb

@jasnell jasnell closed this Mar 22, 2017
@vsemozhetbyt vsemozhetbyt deleted the benchmark-progress branch March 22, 2017 08:43
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
Add a space for minimal readability.

PR-URL: #11925
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants