-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: gcc version is at least 4.8.5 at BUILDING.md #11840
Conversation
First commit LGTM, thanks. The |
Hello. |
The latest version of 4.8 available for 12.04 is 4.8.4. It is not able to build V8 from version 5.7 and does not satisfy the requirements to build Node.js. Refs: nodejs/node#11840 Refs: nodejs/v8#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I see some discussion about requiring 4.9 in other issues.
We'll probably drop g++ 4.8 for node 8.0. Bumping the baseline from 4.8.0 to 4.8.5 for <= v7.x is a good idea, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you mention in the commit log that the bump is because of compiler bugs in g++ < 4.8.5?
No Problem. I will do rebase these commits to one commit after cloning this huge repo slowly because of Chinese GFW :( |
Oh, I suppose that whoever merges this can amend the commit log. |
bumping the baseline from gcc 4.8.0 to gcc 4.8.5 because of compiler bugs in g++ < 4.8.5.
It looks like cannot rebase the PR which have already issued without
Many Thanks :D |
BTW, 4.8.5 is a good interim version IMO since the |
>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: #11840 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 746339e with amended commit log per @bnoordhuis' request |
>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: nodejs#11840 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: nodejs#11840 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
is this also accurate for v6.x? |
Based on:
I'd say so. |
>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: #11840 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
@bnoordhuis I note that this never happened, do you know if it needs to (i.e. will 4.8.5 be okay for the lifetime of v8.x)? |
@gibfahn C++11 support is not 100% functional in 4.8.x. Updating the requirements is still a good idea, IMO; we don't want to be hampered by compiler bugs. I'll file a pull request. |
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. Refs: nodejs#11840
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
The latest version of 4.8 available for 12.04 is 4.8.4. It is not able to build V8 from version 5.7 and does not satisfy the requirements to build Node.js. Refs: nodejs/node#11840 Refs: nodejs/v8#5
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
>= 4.8.5 is required because of compiler bugs in earlier versions PR-URL: nodejs/node#11840 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
This PR is inspired by #10388 when I try to compile the node v6.x with gcc 4.8.0 :(. I check the prerequisites at BUILDING.md and It tell me that gcc version at least is 4.8.0 which is actually out of date (Aslo a typo about
or
).