Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu: bump gcc to 4.9 on 12.04 #650

Closed
wants to merge 1 commit into from
Closed

ubuntu: bump gcc to 4.9 on 12.04 #650

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 14, 2017

The latest version of 4.8 available for 12.04 is 4.8.4.
It is not able to build V8 from version 5.7 and does not
satisfy the requirements to build Node.js.

Refs: nodejs/node#11840
Refs: nodejs/v8#5

/cc @nodejs/build @bnoordhuis @rvagg

bnoordhuis

This comment was marked as off-topic.

mhdawson

This comment was marked as off-topic.

jbergstroem

This comment was marked as off-topic.

@targos
Copy link
Member Author

targos commented Mar 21, 2017

ping. I haven't tested either but I think it's important to test this (and update the machines) soon.
It is blocking nodejs/node#11752.

@jbergstroem
Copy link
Member

Ah. Well, seeing how at least one other build member agrees I'll log in to one of our testers and replace it. Will update this issue.

@jbergstroem
Copy link
Member

Edit: all three builders now runs gcc 4.9. Looks like there were symlinks missing for ccache so i fixed that as well. Please let me know how testing goes and if we need to do something else.

@targos
Copy link
Member Author

targos commented Mar 22, 2017

I started a build with V8 5.7 and it's fully green on Linux: https://ci.nodejs.org/job/node-test-commit-linux/8603/

jbergstroem

This comment was marked as off-topic.

@targos
Copy link
Member Author

targos commented Mar 29, 2017

This seems to cause a problem with clang 3.4.1. https://ci.nodejs.org/job/node-test-commit-linux/8680/nodes=ubuntu1204-clang341-64/

@bnoordhuis
Copy link
Member

@targos The ubuntu1204-clang341-64 buildbot was taken out of commission. Does that mean this pull request can go through now?

@targos
Copy link
Member Author

targos commented May 15, 2017

Yes, I think so.

@targos
Copy link
Member Author

targos commented Jun 19, 2017

ping @nodejs/build

@gibfahn
Copy link
Member

gibfahn commented Jun 19, 2017

I'm okay with this landing, but we're trying to move to the scripts in ansible/, so this change probably needs to be made there as well.

@targos
Copy link
Member Author

targos commented Jun 19, 2017

I can't find the place where Ubuntu 1204 is configured in ansible/

@gibfahn
Copy link
Member

gibfahn commented Jun 19, 2017

I can't find the place where Ubuntu 1204 is configured in ansible/

It might not have been added yet, I haven't had a chance to check out the new scripts, that's more a question for @jbergstroem @joaocgreis @piccoloaiutante

@piccoloaiutante
Copy link
Member

@targos I think you could add a new section at the end of https://github.com/nodejs/build/blob/master/ansible/roles/baselayout/vars/main.yml like this:

ubuntu12: [
   'ccache',
   'gcc-4.9',
   'g++-4.9',
   'git',
]

is it correct @jbergstroem ?

The latest version of 4.8 available for 12.04 is 4.8.4.
It is not able to build V8 from version 5.7 and does not
satisfy the requirements to build Node.js.

Refs: nodejs/node#11840
Refs: nodejs/v8#5
@targos
Copy link
Member Author

targos commented Jun 19, 2017

@piccoloaiutante OK thank you. I added it. Let me know if something else is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants