util: convert inspect.styles to prototype-less object #11624

nem035 · 2017-03-01T03:20:21Z

Use a prototype-less object for inspect.styles and inspect.colors to allow free modification of Object.protototype in the REPL.

Fixes: #11614

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

util

addaleax

LGTM, this won’t hurt.

addaleax · 2017-03-01T15:09:02Z

lib/util.js

@@ -183,7 +183,7 @@ inspect.colors = {
 };


You can do inspect.colors in the same PR here, too

TimothyGu · 2017-03-01T16:56:32Z

lib/util.js

@@ -181,9 +181,10 @@ inspect.colors = {
  'red': [31, 39],
  'yellow': [33, 39]
 };
+inspect.colors = Object.assign(Object.create(null), colors);


Can this be simplified to

inspect.colors = Object.assign(Object.create(null), { 'bold': //... });

Doesn't seem like colors and styles are likely to be used elsewhere.

Sure, my initial thought was that separating is cleaner but I see your point. Not sure what the policy is to make this change, how many reviewers need to agree?

@nem035 You can make this change if it makes sense to you, there are no fixed rules so as long as nobody explicitly objects to the current state of the PR.

Fwiw I’d be in favour of @TimothyGu’s suggestion.

I agree that this would be cleaner. The change is added.

…ects Use a prototype-less object for inspect.styles and inspect.colors to allow modification of Object.prototype in the REPL. Fixes: nodejs#11614

TimothyGu

I would be in favor of using something like a distinct class (like StorageObject) for performance. But since I'm unsure how performance-sensitive the colorization code really is, I'm more than okay with this going in without that change.

addaleax · 2017-03-05T13:11:34Z

CI: https://ci.nodejs.org/job/node-test-commit/8275/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/623/

jasnell · 2017-03-06T21:13:15Z

Unrelated failure on freebsd.
(It does look like the doctool test may be flaky on freebsd tho)

…ects Use a prototype-less object for inspect.styles and inspect.colors to allow modification of Object.prototype in the REPL. Fixes: #11614 PR-URL: #11624 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]>

jasnell · 2017-03-06T21:16:35Z

Landed in aab0d20

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](nodejs@4a7233c178)] [nodejs#12892](nodejs#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](nodejs@d2d32ea5a2)] [nodejs#11968](nodejs#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](nodejs@7eb1b4658e)] [nodejs#12141](nodejs#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](nodejs@beca3244e2)] [nodejs#10236](nodejs#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](nodejs@97a77288ce)] [nodejs#12348](nodejs#12348), [[`d75fdd96aa`](nodejs@d75fdd96aa)] [nodejs#10423](nodejs#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](nodejs@627ecee9ed)] [nodejs#10653](nodejs#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](nodejs@f18e08d820)] [nodejs#9744](nodejs#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](nodejs@3c3b36af0f)] [nodejs#12936](nodejs#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](nodejs@60d1aac8d2)] [nodejs#12784](nodejs#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](nodejs@84dabe8373)] [nodejs#12489](nodejs#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](nodejs@7a55e34ef4)] [nodejs#10467](nodejs#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](nodejs@3c2a9361ff)] [nodejs#9683](nodejs#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](nodejs@90403dd1d0)] [nodejs#11567](nodejs#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](nodejs@d3480776c7)] [nodejs#11259](nodejs#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](nodejs@fb71ba4921)] [nodejs#11355](nodejs#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](nodejs@3e6f1032a4)] [nodejs#10805](nodejs#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](nodejs@5de3cf099c)] [nodejs#10116](nodejs#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](nodejs@84a23391f6)] [nodejs#12113](nodejs#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](nodejs@56e881d0b0)] [nodejs#11975](nodejs#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](nodejs@03e89b3ff2)] [nodejs#10116](nodejs#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](nodejs@dd20e68b0f)] [nodejs#12725](nodejs#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](nodejs@3f27f02da0)] [nodejs#11599](nodejs#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (nodejs@ec7cbaf266)] [nodejs#12995](nodejs#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](nodejs@a16b570f8c)] [nodejs#11968](nodejs#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](nodejs@010f864426)] [nodejs#12949](nodejs#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](nodejs@a5f91ab230)] [nodejs#11689](nodejs#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](nodejs@8a7db9d4b5)] [nodejs#12087](nodejs#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](nodejs@b6e1d22fa6)] [nodejs#12925](nodejs#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](nodejs@07c7f198db)] [nodejs#12828](nodejs#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](nodejs@348cc80a3c)] [nodejs#5923](nodejs#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](nodejs@a2ae08999b)] [nodejs#11349](nodejs#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](nodejs@d523eb9c40)] [nodejs#11447](nodejs#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](nodejs@d080ead0f9)] [nodejs#12710](nodejs#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](nodejs@5bfd13b81e)] [nodejs#9726](nodejs#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](nodejs@455e6f1dd8)] [nodejs#11708](nodejs#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](nodejs@aab0d202f8)] [nodejs#11624](nodejs#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](nodejs@99da8e8e02)] [nodejs#12442](nodejs#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](nodejs@91383e47fd)] [nodejs#12001](nodejs#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](nodejs@b514bd231e)] [nodejs#11391](nodejs#11391).

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](4a7233c178)] [#12892](#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](d2d32ea5a2)] [#11968](#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](7eb1b4658e)] [#12141](#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](beca3244e2)] [#10236](#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](97a77288ce)] [#12348](#12348), [[`d75fdd96aa`](d75fdd96aa)] [#10423](#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](627ecee9ed)] [#10653](#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](f18e08d820)] [#9744](#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](3c3b36af0f)] [#12936](#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](60d1aac8d2)] [#12784](#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](84dabe8373)] [#12489](#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](7a55e34ef4)] [#10467](#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](3c2a9361ff)] [#9683](#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](90403dd1d0)] [#11567](#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](d3480776c7)] [#11259](#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](fb71ba4921)] [#11355](#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](3e6f1032a4)] [#10805](#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](5de3cf099c)] [#10116](#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](84a23391f6)] [#12113](#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](56e881d0b0)] [#11975](#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](03e89b3ff2)] [#10116](#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](dd20e68b0f)] [#12725](#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](3f27f02da0)] [#11599](#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (ec7cbaf266)] [#12995](#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](a16b570f8c)] [#11968](#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](010f864426)] [#12949](#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](a5f91ab230)] [#11689](#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](8a7db9d4b5)] [#12087](#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](b6e1d22fa6)] [#12925](#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](07c7f198db)] [#12828](#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](348cc80a3c)] [#5923](#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](a2ae08999b)] [#11349](#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](d523eb9c40)] [#11447](#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](d080ead0f9)] [#12710](#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](5bfd13b81e)] [#9726](#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](455e6f1dd8)] [#11708](#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](aab0d202f8)] [#11624](#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](99da8e8e02)] [#12442](#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](91383e47fd)] [#12001](#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](b514bd231e)] [#11391](#11391).

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Mar 1, 2017

jasnell requested a review from mscdex March 1, 2017 05:23

addaleax approved these changes Mar 1, 2017

View reviewed changes

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 1, 2017

jasnell approved these changes Mar 1, 2017

View reviewed changes

cjihrig approved these changes Mar 1, 2017

View reviewed changes

nem035 force-pushed the issue-11614 branch 3 times, most recently from 4de231e to 305ff38 Compare March 1, 2017 16:33

TimothyGu reviewed Mar 1, 2017

View reviewed changes

util: convert inspect.styles and inspect.colors to prototype-less obj…

f3e63ea

…ects Use a prototype-less object for inspect.styles and inspect.colors to allow modification of Object.prototype in the REPL. Fixes: nodejs#11614

nem035 force-pushed the issue-11614 branch from 305ff38 to f3e63ea Compare March 1, 2017 17:14

TimothyGu approved these changes Mar 1, 2017

View reviewed changes

jasnell closed this Mar 6, 2017

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

This was referenced Mar 7, 2020

[Snyk] Security upgrade eslint from 3.19.0 to 6.0.0 adamlaska/node#11

Open

[Snyk] Fix for 1 vulnerabilities adamlaska/node#12

Open

[Snyk] Fix for 1 vulnerabilities adamlaska/node#14

Open

aliscco mentioned this pull request Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#962

Open

leonardoadame mentioned this pull request Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#377

Open

This was referenced Dec 1, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#966

Open

[Snyk] Security upgrade eslint from 4.18.2 to 6.0.0 aliscco/alisco-node#968

Open

This was referenced Dec 1, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 leonardoadame/node#391

Open

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#397

Open

This was referenced Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1001

Open

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#1012

Open

adamlaska mentioned this pull request Dec 2, 2023

[Snyk] Fix for 1 vulnerabilities adamlaska/node#132

Open

aliscco mentioned this pull request Dec 2, 2023

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1015

Open

leonardoadame mentioned this pull request Dec 2, 2023

[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 leonardoadame/node#426

Open

leonardoadame mentioned this pull request Dec 2, 2023

[Snyk] Security upgrade eslint from 4.12.1 to 6.0.0 leonardoadame/node#445

Open

This was referenced Dec 2, 2023

[Snyk] Security upgrade eslint from 2.13.1 to 6.0.0 aliscco/alisco-node#1040

Open

[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1050

Open

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1053

Open

This was referenced Dec 2, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#453

Open

[Snyk] Security upgrade eslint from 5.7.0 to 6.0.0 leonardoadame/node#455

Open

This was referenced Dec 2, 2023

[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#1066

Open

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#1067

Open

This was referenced Dec 3, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477

Open

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#478

Open

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 leonardoadame/node#493

Open

aliscco mentioned this pull request Dec 3, 2023

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#1097

Open

leonardoadame mentioned this pull request Dec 3, 2023

[Snyk] Security upgrade eslint from 4.18.2 to 6.0.0 leonardoadame/node#505

Open

aliscco mentioned this pull request Dec 3, 2023

[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 aliscco/alisco-node#1124

Open

leonardoadame mentioned this pull request Dec 5, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#543

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: convert inspect.styles to prototype-less object #11624

util: convert inspect.styles to prototype-less object #11624

nem035 commented Mar 1, 2017 •

edited

Loading

addaleax left a comment

addaleax Mar 1, 2017

TimothyGu Mar 1, 2017

nem035 Mar 1, 2017

addaleax Mar 1, 2017

nem035 Mar 1, 2017

TimothyGu left a comment

addaleax commented Mar 5, 2017

jasnell commented Mar 6, 2017

jasnell commented Mar 6, 2017

util: convert inspect.styles to prototype-less object #11624

util: convert inspect.styles to prototype-less object #11624

Conversation

nem035 commented Mar 1, 2017 • edited Loading

Checklist

Affected core subsystem(s)

addaleax left a comment

Choose a reason for hiding this comment

addaleax Mar 1, 2017

Choose a reason for hiding this comment

TimothyGu Mar 1, 2017

Choose a reason for hiding this comment

nem035 Mar 1, 2017

Choose a reason for hiding this comment

addaleax Mar 1, 2017

Choose a reason for hiding this comment

nem035 Mar 1, 2017

Choose a reason for hiding this comment

TimothyGu left a comment

Choose a reason for hiding this comment

addaleax commented Mar 5, 2017

jasnell commented Mar 6, 2017

jasnell commented Mar 6, 2017

nem035 commented Mar 1, 2017 •

edited

Loading