http: should support userland Agent

PR-URL: #11567 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Mar 26, 2017 · 90403dd · 90403dd
1 parent 20b1823
commit 90403dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -89,9 +89,9 @@ function ClientRequest(options, cb) {
     }
     // Explicitly pass through this statement as agent will not be used
     // when createConnection is provided.
-  } else if (!(agent instanceof Agent.Agent)) {
+  } else if (typeof agent.addRequest !== 'function') {
     throw new TypeError(
-      'Agent option must be an instance of http.Agent, undefined or false.'
+      'Agent option must be an Agent-like object, undefined, or false.'
     );
   }
   this.agent = agent;

diff --git a/test/parallel/test-http-client-reject-unexpected-agent.js b/test/parallel/test-http-client-reject-unexpected-agent.js
@@ -49,7 +49,7 @@ server.listen(0, baseOptions.host, common.mustCall(function() {
   failingAgentOptions.forEach((agent) => {
     assert.throws(
       () => createRequest(agent),
-      /^TypeError: Agent option must be an instance of http.Agent/,
+      /^TypeError: Agent option must be an Agent-like object/,
       `Expected typeof agent: ${typeof agent} to be rejected`
     );
   });