genv8constants fails to extract all symbols with binutils 2.41 #49991

citrus-it · 2023-10-01T11:32:41Z

Version

Occurs on 12, 14, 16, 18

Platform

SunOS bloody 5.11 omnios-master-f42c5dbbece i86pc i386 i86pc

Subsystem

tools

What steps will reproduce the bug?

Attempting to build node on illumos and including --with-dtrace fails with binutils 2.41. It worked with previous versions of binutils.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

dtrace: failed to compile script src/v8ustack.d: line 264: failed to resolve V8DBG_SMITAG: Unknown variable name

Additional information

This is caused by a change in behaviour in objdump from binutils 2.41 where the content of .bss sections is no longer included in disassembly output, even if -z is passed.

See https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8

I have a patch for this and will open a PR once I've finished testing it.

The text was updated successfully, but these errors were encountered:

Objdump in recent versions of GNU binutils ignores bss sections unless they are specifically selected with the '-j' option. Symbols from these sections are needed for dtrace support. To fix this while retaining compatibility with previous versions of binutils, change to a two pass approach. The first pass extracts the list of unique sections, and the second pass invokes objdump with '-j' options for each of them. Fixes: nodejs#49991

Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: nodejs#49991

Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: #49991 PR-URL: #50023 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

… 2.41 * With binutils 2.41 build fails as following. LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.host:/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src/node_dtrace_ustack.o" dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name * This is because behaviour of objdump has changes with binutils 2.41. [1][2] * On upstream DTrace support itself has been removed with Node.js 19.x. * There is a pull request that says it fixes build error. [3] I tried it but unfortunately it doesn't work as is expected. * Upstream suggests me to remove DTrace support. [4] Reference: nodejs/node#49991 (comment) [1] Reference: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2] Reference: nodejs/node#49992 [3] Reference: nodejs/node#49992 (comment) [4]

… 2.41 * With binutils 2.41 build fails as following. LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/lib.host:/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj.target/libnode/src/node_dtrace_ustack.o" dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name * This is because behaviour of objdump has changes with binutils 2.41. [1][2] * On upstream DTrace support itself has been removed with Node.js 19.x. * There is a pull request that says it fixes build error. [3] I tried it but unfortunately it doesn't work as is expected. * Upstream suggests me to remove DTrace support. [4] Reference: nodejs/node#49991 (comment) [1] Reference: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2] Reference: nodejs/node#49992 [3] Reference: nodejs/node#49992 (comment) [4]

Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: nodejs#49991 PR-URL: nodejs#50023 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>