Skip to content

Commit 22e5c64

Browse files
Yasuhiro KimuraYasuhiro Kimura
Yasuhiro Kimura
authored and
Yasuhiro Kimura
committed
www/node18: Remove DTrace support to fix build with upcoming binutils 2.41
* With binutils 2.41 build fails as following. LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/lib.host:/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node18/work/node-v18.18.2/out/Release/obj.target/libnode/src/node_dtrace_ustack.o" dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name * This is because behaviour of objdump has changes with binutils 2.41. [1][2] * On upstream DTrace support itself has been removed with Node.js 19.x. * There is a pull request that says it fixes build error. [3] I tried it but unfortunately it doesn't work as is expected. * Upstream suggests me to remove DTrace support. [4] Reference: nodejs/node#49991 (comment) [1] Reference: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2] Reference: nodejs/node#49992 [3] Reference: nodejs/node#49992 (comment) [4]
1 parent 802020b commit 22e5c64

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

www/node18/Makefile

+2-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
PORTNAME= node
22
PORTVERSION= ${NODEJS_PORTVERSION}
3+
PORTREVISION= 1
34
DISTVERSIONPREFIX= v
45
CATEGORIES= www
56
MASTER_SITES= https://nodejs.org/dist/v${PORTVERSION}/
@@ -52,23 +53,13 @@ SHEBANG_FILES= deps/v8/third_party/inspector_protocol/*.py \
5253
tools/*.py \
5354
tools/inspector_protocol/*.py
5455

55-
OPTIONS_DEFINE= BUNDLED_SSL DOCS DTRACE NLS
56-
OPTIONS_DEFAULT=DTRACE
57-
.if !exists(/usr/sbin/dtrace)
58-
OPTIONS_EXCLUDE+= DTRACE
59-
.endif
60-
OPTIONS_EXCLUDE_aarch64= DTRACE
61-
OPTIONS_EXCLUDE_armv6= DTRACE
62-
OPTIONS_EXCLUDE_armv7= DTRACE
63-
OPTIONS_EXCLUDE_powerpc64= DTRACE
64-
OPTIONS_EXCLUDE_powerpc64le= DTRACE
56+
OPTIONS_DEFINE= BUNDLED_SSL DOCS NLS
6557
OPTIONS_SUB= yes
6658
BUNDLED_SSL_DESC= Use bundled OpenSSL implementation from node.js
6759

6860
BUNDLED_SSL_CONFIGURE_OFF= --openssl-use-def-ca-store --shared-openssl
6961
BUNDLED_SSL_RUN_DEPENDS_OFF= ca_root_nss>=0:security/ca_root_nss
7062
BUNDLED_SSL_USES_OFF= ssl
71-
DTRACE_CONFIGURE_ON= --with-dtrace
7263
NLS_BUILD_DEPENDS= icu>=69.1:devel/icu
7364
NLS_CONFIGURE_ON= --with-intl=system-icu
7465
NLS_LIB_DEPENDS= libicui18n.so:devel/icu

www/node18/pkg-plist

-1
Original file line numberDiff line numberDiff line change
@@ -2272,7 +2272,6 @@ include/node/v8-wasm.h
22722272
include/node/v8-weak-callback-info.h
22732273
include/node/v8.h
22742274
include/node/v8config.h
2275-
%%DTRACE%%lib/dtrace/node.d
22762275
lib/node_modules/corepack/CHANGELOG.md
22772276
lib/node_modules/corepack/LICENSE.md
22782277
lib/node_modules/corepack/README.md

0 commit comments

Comments
 (0)