Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky parallel/test-http-dns-error.js #27487

Closed
mscdex opened this issue Apr 30, 2019 · 0 comments · Fixed by #27500
Closed

Investigate flaky parallel/test-http-dns-error.js #27487

mscdex opened this issue Apr 30, 2019 · 0 comments · Fixed by #27500
Labels
dns Issues and PRs related to the dns subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Apr 30, 2019

  • Version: v10.x
  • Platform: Windows
  • Subsystem: test

On test-azure_msft-win2016-x64-4 with VS2017, parallel/test-http-dns-error.js fails with:

19:37:06 not ok 207 parallel/test-http-dns-error
19:37:06   ---
19:37:06   duration_ms: 0.202
19:37:06   severity: fail
19:37:06   exitcode: 1
19:37:06   stack: |-
19:37:06     assert.js:85
19:37:06       throw new AssertionError(obj);
19:37:06       ^
19:37:06     
19:37:06     AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
19:37:06     + expected - actual
19:37:06     
19:37:06     - 'EAI_FAIL'
19:37:06     + 'ENOTFOUND'
19:37:06         at ClientRequest.<anonymous> (c:\workspace\node-test-binary-windows\test\parallel\test-http-dns-error.js:48:12)
19:37:06         at ClientRequest.<anonymous> (c:\workspace\node-test-binary-windows\test\common\index.js:379:15)
19:37:06         at ClientRequest.emit (events.js:198:13)
19:37:06         at TLSSocket.socketErrorListener (_http_client.js:392:9)
19:37:06         at TLSSocket.emit (events.js:198:13)
19:37:06         at emitErrorNT (internal/streams/destroy.js:91:8)
19:37:06         at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
19:37:06         at process._tickCallback (internal/process/next_tick.js:63:19)

I think that the errCode could be made an array of strings instead of being set to a string to allow for multiple acceptable error codes.

@mscdex mscdex added flaky-test Issues and PRs related to the tests with unstable failures on the CI. dns Issues and PRs related to the dns subsystem. http Issues or PRs related to the http subsystem. labels Apr 30, 2019
cjihrig added a commit to cjihrig/node that referenced this issue May 3, 2019
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: nodejs#27500
Fixes: nodejs#27487
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this issue May 4, 2019
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: #27500
Fixes: #27487
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 24, 2020
EAI_FAIL is expected on OpenBSD, and has been observed on
platforms such as FreeBSD and Windows. This commit makes
EAI_FAIL an acceptable error code on all platforms.

PR-URL: #27500
Fixes: #27487
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant