test: allow EAI_FAIL in test-http-dns-error.js

EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: nodejs#27500 Fixes: nodejs#27487 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
cjihrig · May 3, 2019 · 50364d9 · 50364d9
1 parent d0667e8
commit 50364d9
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/test/parallel/test-http-dns-error.js b/test/parallel/test-http-dns-error.js
@@ -32,9 +32,7 @@ const https = require('https');
 const host = '*'.repeat(64);
 const MAX_TRIES = 5;
 
-let errCode = 'ENOTFOUND';
-if (common.isOpenBSD)
-  errCode = 'EAI_FAIL';
+const errCodes = ['ENOTFOUND', 'EAI_FAIL'];
 
 function tryGet(mod, tries) {
   // Bad host name should not throw an uncatchable exception.
@@ -45,7 +43,7 @@ function tryGet(mod, tries) {
       tryGet(mod, ++tries);
       return;
     }
-    assert.strictEqual(err.code, errCode);
+    assert(errCodes.includes(err.code), err);
   }));
   // http.get() called req1.end() for us
 }
@@ -61,7 +59,7 @@ function tryRequest(mod, tries) {
       tryRequest(mod, ++tries);
       return;
     }
-    assert.strictEqual(err.code, errCode);
+    assert(errCodes.includes(err.code), err);
   }));
   req.end();
 }