-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node 8.6 assumes llvm on FreeBSD #16257
Comments
mscdex
added
build
Issues and PRs related to build files or the CI.
freebsd
Issues and PRs related to the FreeBSD platform.
labels
Oct 17, 2017
A pull request would be welcome. |
mmarchini
pushed a commit
to mmarchini/node
that referenced
this issue
Nov 27, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). If LLVM wasn't installed, llvm_version wasn't being defined, breaking the build. Fixes: nodejs#16257
Thanks! |
MylesBorins
pushed a commit
that referenced
this issue
Dec 12, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737 Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Dec 12, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737 Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Dec 12, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737 Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
gibfahn
pushed a commit
that referenced
this issue
Dec 19, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737 Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
gibfahn
pushed a commit
that referenced
this issue
Dec 20, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737 Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sorry for commenting on such an old thread, but just to clarify I would mention that the solution for FreeBSD is using Node version at least 8.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building node 8.6 for PowerPC (uses gcc, not clang), I see the following error:
gyp: name 'llvm_version' is not defined while evaluating condition 'llvm_version
< "4.0"' in /wrkdirs/usr/ports/www/node/work/node-v8.6.0/node.gyp while trying
to load /wrkdirs/usr/ports/www/node/work/node-v8.6.0/node.gyp
creating ./icu_config.gypi
This appears to have been introduced by Pull Request #14077 .
The text was updated successfully, but these errors were encountered: