Skip to content

Commit

Permalink
build: fix bsd build with gcc
Browse files Browse the repository at this point in the history
BSD build with GCC was broken because it was checking for the llvm_version
variable on common.gypi, even though llvm wasn't installed (or needed). If
LLVM wasn't installed, llvm_version wasn't being defined, breaking the build.

Fixes: nodejs#16257
  • Loading branch information
Matheus Marchini authored and Matheus Marchini committed Nov 27, 2017
1 parent 4ca4db0 commit 62d7469
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
}],
['OS=="freebsd"', {
'conditions': [
['llvm_version < "4.0"', {
['"0" < llvm_version < "4.0"', {
# Use this flag because on FreeBSD std::pairs copy constructor is non-trivial.
# Doesn't apply to llvm 4.0 (FreeBSD 11.1) or later.
# Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html
Expand Down
3 changes: 1 addition & 2 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -692,8 +692,7 @@ def check_compiler(o):
# to a version that is not completely ancient.
warn('C compiler too old, need gcc 4.2 or clang 3.2 (CC=%s)' % CC)

if is_clang:
o['variables']['llvm_version'] = get_llvm_version(CC)
o['variables']['llvm_version'] = get_llvm_version(CC) if is_clang else 0

# Need xcode_version or gas_version when openssl asm files are compiled.
if options.without_ssl or options.openssl_no_asm or options.shared_openssl:
Expand Down
1 change: 0 additions & 1 deletion deps/openssl/openssl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
'is_clang': 0,
'gcc_version': 0,
'openssl_no_asm%': 0,
'llvm_version%': 0,
'xcode_version%': 0,
'gas_version%': 0,
'openssl_fips%': 'false',
Expand Down

0 comments on commit 62d7469

Please sign in to comment.