Skip to content

Commit

Permalink
test: end tls connection with some data
Browse files Browse the repository at this point in the history
In openssl-1.1.1e the client doesn't seem to like having the TLS
connection shut down with no data sent, so send an empty string. A
number of related issues showed up in the TLS1.3 port, so this is
not entirely surprising.

PR-URL: #32328
Backport-PR-URL: #32443
Fixes: #32210
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
sam-github authored and BethGriggs committed Mar 24, 2020
1 parent 76033c5 commit 89692ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-tls-session-cache.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function doTest(testOptions, callback) {
throw er;
});
++requestCount;
cleartext.end();
cleartext.end('');
});
server.on('newSession', function(id, data, cb) {
++newSessionCount;
Expand Down

0 comments on commit 89692ff

Please sign in to comment.