This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
dns: remove AI_V4MAPPED hint flag on FreeBSD #9212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD does not support V4MAPPED. PR-URL: nodejs/node#332 Reviewed-By: Ben Noordhuis <[email protected]>
|
|
||
| // FIXME(indutny): V4MAPPED on FreeBSD results in EAI_BADFLAGS, because | ||
| // the libc does not support it | ||
| if (process.platform === 'freebsd' && family !== 6) |
There was a problem hiding this comment.
since the flag is simply invalid, why adding && family !== 6 ?
Another (more elaborate) question is whether mapped/not-mapped IPv4 addresses should just have been abstracted from the clients.
|
@cjihrig I would close this in favor of #18204. See #8540 (comment) for the rationale behind my suggestion. Please let me know what you think! |
|
@cjihrig me too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of nodejs/node@04bea9f
Closes #9204