Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

net: do not set V4MAPPED on FreeBSD #18204

Closed
wants to merge 1 commit into from
Closed

net: do not set V4MAPPED on FreeBSD #18204

wants to merge 1 commit into from

Conversation

misterdjules
Copy link

V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes #8540.

@misterdjules misterdjules added this to the 0.12.3 milestone Apr 21, 2015
@misterdjules misterdjules mentioned this pull request Apr 21, 2015
Closed
@misterdjules
Copy link
Author

Tested on FreeBSD 10.1-RELEASE-p6.

@misterdjules
Copy link
Author

I didn't add a regression test for this specific problem since net.connect is used in lots of different places in the current simple tests suite.

@misterdjules
Copy link
Author

/cc @joyent/node-coreteam.

@misterdjules misterdjules mentioned this pull request Apr 21, 2015
Closed
@misterdjules misterdjules mentioned this pull request Apr 21, 2015
Closed
@cjihrig
Copy link

cjihrig commented Apr 21, 2015

LGTM if the CI is happy. It might be worth adding this to the docs.

@indutny
Copy link
Member

indutny commented Apr 21, 2015

LGTM

@misterdjules
Copy link
Author

@cjihrig @indutny Thanks! @cjihrig I don't think we currently mention the usage of V4MAPPED in the API docs, could you please elaborate on what you had in mind?

@cjihrig
Copy link

cjihrig commented Apr 21, 2015

@misterdjules maybe just mention here that V4MAPPED does not work on FreeBSD.

@misterdjules
Copy link
Author

@cjihrig Good catch, will do and thank you!

net: do not set V4MAPPED on FreeBSD
1d47b40 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes nodejs#8540 and nodejs#9204.
@misterdjules
Copy link
Author

@cjihrig Updated.

@cjihrig
Copy link

cjihrig commented Apr 25, 2015

LGTM

misterdjules pushed a commit that referenced this pull request Apr 28, 2015
net: do not set V4MAPPED on FreeBSD
0e392f3 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes #8540 and #9204.

Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #18204
@misterdjules
Copy link
Author

Thank you, landed in 0e392f3.

cjihrig pushed a commit to nodejs/node that referenced this pull request May 15, 2015
@cjihrig
net: do not set V4MAPPED on FreeBSD
6f457a0 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
rvagg pushed a commit to rvagg/io.js that referenced this pull request May 27, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
853a2b3 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: nodejs#1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Jun 17, 2015
@chrisdickinson
net: do not set V4MAPPED on FreeBSD
7a3e354 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Jul 22, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
a2ac312 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Jul 24, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
f0bccf9 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Jul 30, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
a78629e 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Aug 1, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
668ab61 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Aug 3, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
c6b9e2b 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Aug 4, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
d6a97eb 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules pushed a commit to nodejs/node that referenced this pull request Aug 4, 2015
@rvagg
net: do not set V4MAPPED on FreeBSD
9bc2e26 
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.

Fixes: nodejs/node-v0.x-archive#8540
Fixes: nodejs/node-v0.x-archive#9204
PR-URL: nodejs/node-v0.x-archive#18204
PR-URL: #1555
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
freebsd net P-2 pr v0.12
Projects
None yet
Milestone
0.12.3
Development

Successfully merging this pull request may close these issues.
4 participants
@misterdjules @cjihrig @indutny @Nodejs-Jenkins