url.format on client in IE8 returns incorrect format

[AllSpeeds]

IE8 does not deal well with negative numbers in substr. It's a real bummer.

https://github.com/joyent/node/blob/master/lib/url.js#L382

(protocol && protocol.substr(-1) !== ':') protocol += ':';
in IE8 "http:".substr(-1) returns "http:"

Fix:
(protocol && protocol.slice(-1) !== ':') protocol += ':';

[vkurchatkin]

How is it a node issue? If you are using url with browserify it is better to file an issue in the appropriate repository

[indutny]

Wrong repository, sorry. Though, I'll probably accept it if you'll send a pull request for it. Note that there're a couple of other substr(<negative number>) usages out there.

[vkurchatkin]

@indutny what's the point? it seems legit according to the spec

[indutny]

@vkurchatkin indeed it is, but I don't really enjoy having substr calls anyway. Better discuss it in a PR, if there'll be any.

[indutny]

After considering it for another time, I think it's too much for node.