Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to V8 5.0.71.47 #6572

Merged
merged 1 commit into from
May 12, 2016
Merged

deps: upgrade to V8 5.0.71.47 #6572

merged 1 commit into from
May 12, 2016

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented May 4, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

Pick up the latest set of patch level updates from the V8 5.0 branch.
v8/v8@5.0.71.35...5.0.71.47

R= @nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/2497/

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 4, 2016
@bnoordhuis
Copy link
Member

LGTM

@mhdawson
Copy link
Member

mhdawson commented May 4, 2016

CI run of v8 tests in node tree: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/78/

@JungMinu
Copy link
Member

JungMinu commented May 5, 2016

LGTM

@ofrobots
Copy link
Contributor Author

ofrobots commented May 6, 2016

@mhdawson Do you know what is going on with the benchmark,v8test configuration in that v8 tests build? Seems to be breaking since build 76. Is it a flake?

@mhdawson
Copy link
Member

mhdawson commented May 9, 2016

This issue is tracking the known failure in the v8 runs: #6340 which is intermittent.

The failures seen in the one with the update is not obviously related from the output, however, in our internal builds we saw similar failures on AIX and the case was regress/regress-crbug-514081
So its almost certainly the same issue.

I'm going to submit a PR to limit execution of this test 1 one variant.

@mhdawson
Copy link
Member

PR to address regress/regress-crbug-514081 failures - #6678

Pick up the latest set of patch level updates from the V8 5.0 branch.
v8/v8@5.0.71.35...5.0.71.47

PR-URL: nodejs#6572
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: JungMinu - Minwoo Jung <[email protected]>
@ofrobots ofrobots merged commit e16e611 into nodejs:master May 12, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
Pick up the latest set of patch level updates from the V8 5.0 branch.
v8/v8@5.0.71.35...5.0.71.47

PR-URL: #6572
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: JungMinu - Minwoo Jung <[email protected]>
evanlucas added a commit that referenced this pull request May 17, 2016
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)
evanlucas added a commit that referenced this pull request May 17, 2016
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)

As of this release the 6.X line now includes 64-bit binaries for Linux
on Power Systems running in big endian mode in addition to the existing
64-bit binaries for running in little endian mode.

PR-URL: #6810
evanlucas added a commit that referenced this pull request May 17, 2016
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)

As of this release the 6.X line now includes 64-bit binaries for Linux
on Power Systems running in big endian mode in addition to the existing
64-bit binaries for running in little endian mode.

PR-URL: #6810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants