Bump gyp 19495aa #1183
Closed
Bump gyp 19495aa #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joaocgreis PTAL, after we land this we can improve on #1130 (remove |
Tar version 3 performs better and is more well tested than its predecessor. npm will be using this in the near future, so there is no benefit in shipping a node-gyp that uses the slower and less reliable fstream-based tar. This drops support for node 0.x, and thus should be considered a breaking semver-major change. PR-URL: nodejs#1212 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
* dropping support for node < 4 * signal the CI not to test node < 4
If you're providing a path to a header tarball to install, you probably want it to always be re-installed. PR-URL: nodejs#1220 Fixes: nodejs#1216 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
* test: build simple addon in path with non-ascii characters * test: add test-charmap.py PR-URL: nodejs#1203 Reviewed-By: Refael Ackermann <[email protected]>
Enable linking to the platform specific installation instructions PR-URL: nodejs#1225 Reviewed-By: Refael Ackermann <[email protected]>
Lifted verbatim from https://github.com/nodejs/node/blob/master/CONTRIBUTING.md then `s/Node.js/node-gyp/`. PR-URL: nodejs#1229 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Give users reporting bugs a clearer idea of the info that will be helpful when reporting issues. PR-URL: nodejs#1228 Refs: https://github.com/nodejs/node/tree/master/.github Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
@refack Needs a rebase and most likely a new GYP update. |
|
Ack. |
this is a rebase of a981ef8 After bumping gyp to 19495aa Actually I just took the file as is, because of a discontinues patch floating.
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not suitable for environments that only uses the clang toolchain. Since we already assume that the user will provide clang/clang++ through CC/CXX, lean against it (then drop to gcc/g++). PR-URL: nodejs#908 Refs: nodejs/node#6173 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
When generating Android.mk files for HOST binaries, we need to specify the LOCAL_CXX_STL to use when linking. Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as LOCAL_MULTILIB, and since we don't provide flags for both types of builds (32-bit and 64-bit), the build system will try to build both and fail. More details about LOCAL_MULTILIB can be found here: https://source.android.com/source/64-bit-builds.html Signed-off-by: Robert Chiras <[email protected]> PR-URL: nodejs#935 Reviewed-By: Ben Noordhuis <[email protected]>
To make sure platform specific newlines ('\r\n' or '\r') are converted
to '\n' which otherwise will fail eval().
This should handle multiple issues reported on syntax error reading
binding.gyp (partial list):
nodejs#979
nodejs#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24
PR-URL: nodejs#1053
Reviewed-By: Ben Noordhuis <[email protected]>
refack
force-pushed
the
bump-gyp-19495aa
branch
from
9565b08
to
0c98bee
Compare
|
This was referenced Oct 20, 2017
|
🤷♂ would be nice to get a sync, but this is too old now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GYPto latest versionChecklist
npm testpassesAffected core subsystem(s)
gyp