-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete superfluous .patch files. #1122
Conversation
@bnoordhuis but they make rebasing easier... 😞 |
Why? You can just |
Makes it more error prone. Are those commits "sterile"? |
I don't know what you mean by 'sterile.' I also don't understand why you think it's more error prone. Can you elaborate? |
@bnoordhuis "Sterile" as in including only patches tn Assuming the procedure for a
New process will be:
Both obviously works, IMHO 2nd one more fragile. |
I don't think it's all that different. All of this may be academic though because upstream gyp is clearly in maintenance mode. I don't expect any big updates before upstream abandons it completely. |
Cool 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The patch files are unnecessary, they also exist as commits in the history. Delete the files. PR-URL: #1122 Reviewed-By: João Reis <[email protected]>
The patch files are unnecessary, they also exist as commits in the
history. Delete the files.
Refs: #1119