Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two new commit patch GYP code but are missing .patch file #1119

Closed
refack opened this issue Feb 15, 2017 · 2 comments
Closed

Two new commit patch GYP code but are missing .patch file #1119

refack opened this issue Feb 15, 2017 · 2 comments

Comments

@refack
Copy link
Contributor

refack commented Feb 15, 2017

ec5fc36
a04ea30
@bnoordhuis
Copy link
Member

I think I'll remove the .patch files, they just duplicate what's already in git. Thanks for bringing it up though.

@bnoordhuis bnoordhuis mentioned this issue Feb 16, 2017
Merged
@refack
Copy link
Contributor Author

refack commented Feb 16, 2017

What if you want to rebase our changes onto a new GYP version?

@refack refack mentioned this issue Feb 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refack @bnoordhuis