This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Merge nodejs/master #198
Merged
Merge nodejs/master #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitalinfinity - Please review. |
digitalinfinity
approved these changes
Mar 23, 2017
test/parallel/test-util-format.js
Outdated
| return false; | ||
| }); | ||
| } | ||
| assert.strictEqual(util.format('%j', o), '[Circular]'); |
There was a problem hiding this comment.
Curious- do we know how this works now?
There was a problem hiding this comment.
Sorry, didn't understand your question. this means what?
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Mar 24, 2017
Merge nodejs/node@348cc80 as of 2017-03-23 PR-URL: nodejs#198 Signed-off-by: Hitesh Kanwathirtha <[email protected]>
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Mar 24, 2017
Reverted nodejs@374a1d8 because nodejs/node#11854 is present in upstream. Updated v8-version PR-URL: nodejs#198 Signed-off-by: Hitesh Kanwathirtha <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge nodejs/node@348cc80 as of 2017-03-23
Fixes: #187
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test