Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 374a1d8

Browse files
committed
test,chakrashim: Updated v8-version
test: more chakrashim test fixes PR-URL: #186 Reviewed-By: Hitesh Kanwathirtha <[email protected]>
1 parent 4ef4e84 commit 374a1d8

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

deps/chakrashim/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#define V8_MAJOR_VERSION 5
3535
#define V8_MINOR_VERSION 6
3636
#define V8_BUILD_NUMBER 326
37-
#define V8_PATCH_LEVEL 55
37+
#define V8_PATCH_LEVEL 56
3838

3939
// Use 1 for candidates and 0 otherwise.
4040
// (Boolean macro values are not supported by all preprocessors.)

test/inspector/inspector.status

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,5 @@ prefix inspector
1111
[$jsEngine==chakracore]
1212
test-inspector : SKIP
1313
test-inspector-stops-no-file : SKIP
14-
test-not-blocked-on-idle : SKIP
14+
test-not-blocked-on-idle : SKIP
15+
test-inspector-ip-detection : SKIP

test/parallel/parallel.status

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ test-vm-timeout : SKIP
7777
test-whatwg-url-origin-for : SKIP
7878
test-assert-checktag : SKIP
7979
test-process-env-symbols : SKIP
80-
test-util-format : SKIP
80+
test-module-loading-globalpaths : SKIP
8181

8282
[$jsEngine==chakracore && $arch==x64]
8383
test-buffer-includes : SKIP

test/parallel/test-util-format.js

+13-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
require('../common');
23+
const common = require('../common');
2424
const assert = require('assert');
2525
const util = require('util');
2626
const symbol = Symbol('foo');
@@ -83,7 +83,18 @@ assert.strictEqual(util.format('o: %j, a: %j'), 'o: %j, a: %j');
8383
{
8484
const o = {};
8585
o.o = o;
86-
assert.strictEqual(util.format('%j', o), '[Circular]');
86+
if (!common.isChakraEngine) {
87+
assert.strictEqual(util.format('%j', o), '[Circular]');
88+
} else {
89+
assert.throws(() => { util.format('%j', o); }, function(err) {
90+
if (err instanceof TypeError &&
91+
err.message === 'Circular reference in value argument not ' +
92+
'supported') {
93+
return true;
94+
}
95+
return false;
96+
});
97+
}
8798
}
8899

89100
{

0 commit comments

Comments
 (0)