Skip to content

Commit

Permalink
labels: add 'build' for android-configure (#144)
Browse files Browse the repository at this point in the history
  • Loading branch information
mscdex authored and phillipj committed May 14, 2017
1 parent 66eb55f commit 0ee821a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/node-labels.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const subSystemLabelsMap = new Map([
[/^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles)$/, 'build'],
[/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/, 'build'],
[/^vcbuild\.bat$/, ['build', 'windows']],
[/^configure|node\.gyp|common\.gypi$/, 'build'],
[/^(android-)?configure|node\.gyp|common\.gypi$/, 'build'],
// more specific tools
[/^tools\/gyp/, ['tools', 'build']],
[/^tools\/doc\//, ['tools', 'doc']],
Expand Down
11 changes: 11 additions & 0 deletions test/unit/node-labels.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -568,3 +568,14 @@ for (const info of specificTools) {
})
}
})

tap.test('label: "build" when ./android-configure has been changed', (t) => {
const labels = nodeLabels.resolveLabels([
'android-configure'
])

t.same(labels, ['build'])

t.end()
})

0 comments on commit 0ee821a

Please sign in to comment.