labels: add more async_hooks support (#145)

nodejs · May 14, 2017 · 66eb55f · 66eb55f
1 parent f791b50
commit 66eb55f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/node-labels.js b/lib/node-labels.js
@@ -93,7 +93,7 @@ const subSystemLabelsMap = new Map([
 ])
 
 const jsSubsystemList = [
-  'debugger', 'assert', 'buffer', 'child_process', 'cluster', 'console',
+  'debugger', 'assert', 'async_hooks', 'buffer', 'child_process', 'cluster', 'console',
   'crypto', 'dgram', 'dns', 'domain', 'events', 'fs', 'http', 'https', 'module',
   'net', 'os', 'path', 'process', 'querystring', 'readline', 'repl', 'stream',
   'string_decoder', 'timers', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib'
@@ -111,6 +111,7 @@ const exclusiveLabelsMap = new Map([
   [/^test\/cctest\/test_url/, ['test', 'url-whatwg',
                                'dont-land-on-v4.x', 'dont-land-on-v6.x']],
   [/^test\/addons-napi\//, ['test', 'n-api']],
+  [/^test\/async-hooks\//, ['test', 'async_hooks']],
 
   [/^test\//, 'test'],
 

diff --git a/test/unit/node-labels.test.js b/test/unit/node-labels.test.js
@@ -547,6 +547,23 @@ for (const info of specificTools) {
 
       t.same(resolved, labels)
 
+      t.end()
+    })
+  }
+});
+
+[
+  [ ['async_hooks'], ['lib/async_hooks.js'] ],
+  [ ['test', 'async_hooks'], ['test/async-hooks/test-connection.ssl.js'] ]
+].forEach((info) => {
+  const labels = info[0]
+  const files = info[1]
+  for (const file of files) {
+    tap.test(`label: "${labels.join('","')}" when ./${file} has been changed`, (t) => {
+      const resolved = nodeLabels.resolveLabels([file])
+
+      t.same(resolved, labels)
+
       t.end()
     })
   }